Linux RAID subsystem development
 help / color / mirror / Atom feed
From: Xiao Ni <xni@redhat.com>
To: linux-raid@vger.kernel.org
Cc: song@kernel.org, dan.j.williams@intel.com, yuyufen@huawei.com,
	ncroxon@redhat.com, heinzm@redhat.com
Subject: [PATCH 1/1] async_xor: It should add src_offs when dropping destination page
Date: Sun, 25 Apr 2021 17:22:57 +0800	[thread overview]
Message-ID: <1619342577-6034-1-git-send-email-xni@redhat.com> (raw)

Now we support sharing one page if PAGE_SIZE is not equal stripe size. To support this,
it needs to support calculating xor value with different offsets for each r5dev. One
offset array is used to record those offsets.

In RMW mode, parity page is used as a source page. It sets ASYNC_TX_XOR_DROP_DST before
calculating xor value in ops_run_prexor5. So it needs to add src_list and src_offs at
the same time. Now it only needs src_list. So the xor value which is calculated is wrong.
It can cause data corruption problem.

I can reproduce this problem 100% on a POWER8 machine. The steps are:
mdadm -CR /dev/md0 -l5 -n3 /dev/sdb1 /dev/sdc1 /dev/sdd1 --size=3G
mkfs.xfs /dev/md0
mount /dev/md0 /mnt/test
mount: /mnt/test: mount(2) system call failed: Structure needs cleaning.

Fixes: 29bcff787 ("md/raid5: add new xor function to support different page offset")
Signed-off-by: Xiao Ni <xni@redhat.com>
---
 crypto/async_tx/async_xor.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/crypto/async_tx/async_xor.c b/crypto/async_tx/async_xor.c
index a057ecb..6cd7f70 100644
--- a/crypto/async_tx/async_xor.c
+++ b/crypto/async_tx/async_xor.c
@@ -233,6 +233,7 @@ async_xor_offs(struct page *dest, unsigned int offset,
 		if (submit->flags & ASYNC_TX_XOR_DROP_DST) {
 			src_cnt--;
 			src_list++;
+			src_offs++;
 		}
 
 		/* wait for any prerequisite operations */
-- 
2.7.5


             reply	other threads:[~2021-04-25  9:23 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-25  9:22 Xiao Ni [this message]
2021-04-26  6:32 ` [PATCH 1/1] async_xor: It should add src_offs when dropping destination page Song Liu
2021-04-26 10:20   ` Xiao Ni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1619342577-6034-1-git-send-email-xni@redhat.com \
    --to=xni@redhat.com \
    --cc=dan.j.williams@intel.com \
    --cc=heinzm@redhat.com \
    --cc=linux-raid@vger.kernel.org \
    --cc=ncroxon@redhat.com \
    --cc=song@kernel.org \
    --cc=yuyufen@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox