From: "Stephan Müller" <smueller@chronox.de>
To: Gilad Ben-Yossef <gilad@benyossef.com>
Cc: linux-security-module@l.org, Mike Snitzer <snitzer@redhat.com>,
linux-doc@vger.kernel.org, David Howells <dhowells@redhat.com>,
dm-devel@redhat.com, keyrings@vger.kernel.org,
linux-ima-devel@lists.sourceforge.net,
Pavel Shilovsky <pshilov@microsoft.com>,
Alasdair Kergon <agk@redhat.com>,
linux-cifs@vger.kernel.org,
Herbert Xu <herbert@gondor.apana.org.au>,
Jonathan Corbet <corbet@lwn.net>,
Mimi Zohar <zohar@linux.vnet.ibm.com>,
"Serge E. Hallyn" <serge@hallyn.com>,
linux-ima-user@lists.sourceforge.net,
Eric Biggers <ebiggers3@gmail.com>,
linux-raid@vger.kernel.org, linux-fscrypt@vger.kernel.org,
James Morris <james.l.morris@oracle.com>,
Jaegeuk Kim <jaegeuk@kernel.org>, Ofir Drang <ofir.drang@arm.com>,
"Theodore Y. Ts'o" <tytso@mit.edu>,
Dmitry Kasatkin <dmitry.kasatkin@gmail.com>,
samba-technical@lists.samba.org, linux-kernel@vger.kernel.org,
Steve French <sfrench@sam>
Subject: Re: [PATCH v2 04/11] crypto: move drbg to generic async completion
Date: Mon, 29 May 2017 11:04:01 +0200 [thread overview]
Message-ID: <1638335.mkZCLTBCSi@tauon.chronox.de> (raw)
In-Reply-To: <1496046180-21962-5-git-send-email-gilad@benyossef.com>
Am Montag, 29. Mai 2017, 10:22:51 CEST schrieb Gilad Ben-Yossef:
Hi Gilad,
> DRBG is starting an async. crypto op and waiting for it complete.
> Move it over to generic code doing the same.
>
> The code now also passes CRYPTO_TFM_REQ_MAY_SLEEP flag indicating
> crypto request memory allocation may use GFP_KERNEL which should
> be perfectly fine as the code is obviously sleeping for the
> completion of the request any way.
>
> Signed-off-by: Gilad Ben-Yossef <gilad@benyossef.com>
Acked-by: Stephan Müller <smueller@chronox.de>
However, please note that there is a patch "crypto:drbg- Fixes panic in
wait_for_completion call." which adds another init_completion. I guess that
needs conversion to crypto_init_wait as well, once this patch set is accepted.
Ciao
Stephan
next prev parent reply other threads:[~2017-05-29 9:04 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-29 8:22 [PATCH v2 00/11] introduce crypto wait for async op Gilad Ben-Yossef
2017-05-29 8:22 ` [PATCH v2 01/11] crypto: " Gilad Ben-Yossef
2017-06-10 3:43 ` Herbert Xu
2017-06-10 8:05 ` Gilad Ben-Yossef
2017-06-10 9:01 ` Herbert Xu
2017-05-29 8:22 ` [PATCH v2 02/11] crypto: move algif to generic async completion Gilad Ben-Yossef
2017-05-29 8:22 ` [PATCH v2 03/11] crypto: move pub key " Gilad Ben-Yossef
2017-05-29 8:22 ` [PATCH v2 04/11] crypto: move drbg " Gilad Ben-Yossef
2017-05-29 9:04 ` Stephan Müller [this message]
2017-05-29 8:22 ` [PATCH v2 05/11] crypto: move gcm " Gilad Ben-Yossef
2017-05-29 8:22 ` [PATCH v2 06/11] crypto: move testmgr " Gilad Ben-Yossef
2017-05-29 8:22 ` [PATCH v2 07/11] dm: move dm-verity " Gilad Ben-Yossef
2017-05-29 8:22 ` [PATCH v2 08/11] fscrypt: move " Gilad Ben-Yossef
2017-05-29 8:22 ` [PATCH v2 09/11] cifs: " Gilad Ben-Yossef
2017-05-29 8:22 ` [PATCH v2 10/11] ima: " Gilad Ben-Yossef
2017-05-29 8:22 ` [PATCH v2 11/11] crypto: adapt api sample to use async. op wait Gilad Ben-Yossef
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1638335.mkZCLTBCSi@tauon.chronox.de \
--to=smueller@chronox.de \
--cc=agk@redhat.com \
--cc=corbet@lwn.net \
--cc=dhowells@redhat.com \
--cc=dm-devel@redhat.com \
--cc=dmitry.kasatkin@gmail.com \
--cc=ebiggers3@gmail.com \
--cc=gilad@benyossef.com \
--cc=herbert@gondor.apana.org.au \
--cc=jaegeuk@kernel.org \
--cc=james.l.morris@oracle.com \
--cc=keyrings@vger.kernel.org \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-fscrypt@vger.kernel.org \
--cc=linux-ima-devel@lists.sourceforge.net \
--cc=linux-ima-user@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=linux-security-module@l.org \
--cc=ofir.drang@arm.com \
--cc=pshilov@microsoft.com \
--cc=samba-technical@lists.samba.org \
--cc=serge@hallyn.com \
--cc=sfrench@sam \
--cc=snitzer@redhat.com \
--cc=tytso@mit.edu \
--cc=zohar@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox