From: Hannes Reinecke <hare@suse.de>
To: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>
Cc: dm-devel@redhat.com, linux-block@vger.kernel.org,
linux-raid@vger.kernel.org, linux-s390@vger.kernel.org
Subject: Re: [PATCH 2/5] block: simplify and extended the block_bio_merge tracepoint class
Date: Thu, 3 Dec 2020 13:46:30 +0100 [thread overview]
Message-ID: <168a66f3-326f-6cb5-3153-e7ab75e332a6@suse.de> (raw)
In-Reply-To: <20201130175854.982460-3-hch@lst.de>
On 11/30/20 6:58 PM, Christoph Hellwig wrote:
> The block_bio_merge tracepoint class can be reused for most bio-based
> tracepoints. For that is just needs to lose the superflous and rq
'and rq' ?
Do you mean 'q and rq'?
> parameters.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
> block/blk-core.c | 2 +-
> block/blk-merge.c | 4 +-
> block/blk-mq.c | 2 +-
> block/bounce.c | 2 +-
> include/trace/events/block.h | 158 ++++++++---------------------------
> kernel/trace/blktrace.c | 41 +++------
> 6 files changed, 48 insertions(+), 161 deletions(-)
>
Otherwise:
Reviewed-by: Hannes Reinecke <hare@suse.de>
Cheers,
Hannes
--
Dr. Hannes Reinecke Kernel Storage Architect
hare@suse.de +49 911 74053 688
SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), Geschäftsführer: Felix Imendörffer
next prev parent reply other threads:[~2020-12-03 12:47 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-30 17:58 block tracepoint cleanups Christoph Hellwig
2020-11-30 17:58 ` [PATCH 1/5] block: remove the unused block_sleeprq tracepoint Christoph Hellwig
2020-12-03 8:46 ` [dm-devel] " Damien Le Moal
2020-12-03 12:43 ` Hannes Reinecke
2020-11-30 17:58 ` [PATCH 2/5] block: simplify and extended the block_bio_merge tracepoint class Christoph Hellwig
2020-12-03 8:56 ` [dm-devel] " Damien Le Moal
2020-12-03 12:46 ` Hannes Reinecke [this message]
2020-11-30 17:58 ` [PATCH 3/5] block: remove the request_queue argument to the block_split tracepoint Christoph Hellwig
2020-12-03 8:59 ` Damien Le Moal
2020-12-03 12:47 ` Hannes Reinecke
2020-11-30 17:58 ` [PATCH 4/5] block: remove the request_queue argument to the block_bio_remap tracepoint Christoph Hellwig
2020-12-03 9:02 ` [dm-devel] " Damien Le Moal
2020-12-03 12:49 ` Hannes Reinecke
2020-11-30 17:58 ` [PATCH 5/5] block: remove the request_queue to argument request based tracepoints Christoph Hellwig
2020-12-03 9:06 ` [dm-devel] " Damien Le Moal
2020-12-03 12:49 ` Hannes Reinecke
2020-12-03 8:25 ` block tracepoint cleanups Christoph Hellwig
2020-12-03 15:38 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=168a66f3-326f-6cb5-3153-e7ab75e332a6@suse.de \
--to=hare@suse.de \
--cc=axboe@kernel.dk \
--cc=dm-devel@redhat.com \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).