From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Mike Snitzer" Subject: Re: [RFC][PATCH] md: avoid fullsync if a faulty member missed a dirty transition Date: Fri, 9 May 2008 01:08:40 -0400 Message-ID: <170fa0d20805082208y5ad10fe6xbbbaddcbcb7a4736@mail.gmail.com> References: <1207174155-20090-1-git-send-email-snitzer@gmail.com> <18464.134.236488.251879@notabene.brown> <170fa0d20805060458i43c9a4a7r1e30147bdcd40f20@mail.gmail.com> <18466.39418.578722.92979@notabene.brown> <170fa0d20805081311r6b726762ndc83c5f626f0956c@mail.gmail.com> <18467.43895.220708.254814@notabene.brown> <170fa0d20805082142o61462a7dnce7852a6b7c0d21d@mail.gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <170fa0d20805082142o61462a7dnce7852a6b7c0d21d@mail.gmail.com> Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org To: Neil Brown Cc: linux-raid@vger.kernel.org, linux-kernel@vger.kernel.org, paul.clements@steeleye.com List-Id: linux-raid.ids On Fri, May 9, 2008 at 12:42 AM, Mike Snitzer wrote: > Was I supposed to use this latest patch in combination with your > previous patch (to validate_super)? Because you'll note that with > your most recent patch nbd0's events (ev1) is still one less than > sdq's events_cleared. As such the validate_super's "ev1 < > mddev->bitmap->events_cleared" check triggers a full rebuild. > > The kernel log shows: > md: md0 stopped. > md: bind > md: bind > md: kicking non-fresh nbd0 from array! > md: unbind > md: export_rdev(nbd0) > raid1: raid set md0 active with 1 out of 2 mirrors > md0: bitmap initialized from disk: read 13/13 pages, set 0 bits, status: 0 Also, no bits were set in the bitmap.. bitmap_create() must've thrown away the dirty bits. Given your latest patch, does bitmap_create()'s "bitmap->events_cleared == mddev->events" check need to be adjusted? Before I would always see something like: md0: bitmap initialized from disk: read 13/13 pages, set 1 bits, status: 0 Mike