From: Neil Brown <neilb@suse.de>
To: Andrew Morton <akpm@osdl.org>
Cc: linux-raid@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 002 of 4] md: Make 'repair' actually work for raid1.
Date: Wed, 24 Jan 2007 18:27:24 +1100 [thread overview]
Message-ID: <17847.2652.255906.33304@notabene.brown> (raw)
In-Reply-To: message from Andrew Morton on Tuesday January 23
On Tuesday January 23, akpm@osdl.org wrote:
> On Tue, 23 Jan 2007 11:26:52 +1100
> NeilBrown <neilb@suse.de> wrote:
>
> > + for (j = 0; j < vcnt ; j++)
> > + memcpy(page_address(sbio->bi_io_vec[j].bv_page),
> > + page_address(pbio->bi_io_vec[j].bv_page),
> > + PAGE_SIZE);
>
> I trust these BIOs are known to only contain suitably-allocated, MD-private
> pages? Because if these pages can be user pages then this change is
> spectacularly buggy ;)
Your trust is well placed.
This is in the 'resync' path, were all buffers are allocated in lowmem
and are full pages and so-forth, so this is perfectly safe.
NeilBrown
next prev parent reply other threads:[~2007-01-24 7:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-23 0:26 [PATCH 000 of 4] md: Introduction - Assorted bugfixes NeilBrown
2007-01-23 0:26 ` [PATCH 001 of 4] md: Update email address and status for MD in MAINTAINERS NeilBrown
2007-01-23 0:26 ` [PATCH 002 of 4] md: Make 'repair' actually work for raid1 NeilBrown
2007-01-24 6:57 ` Andrew Morton
2007-01-24 7:27 ` Neil Brown [this message]
2007-01-23 0:26 ` [PATCH 003 of 4] md: Make sure the events count in an md array never returns to zero NeilBrown
2007-01-23 0:27 ` [PATCH 004 of 4] md: Avoid reading past the end of a bitmap file NeilBrown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=17847.2652.255906.33304@notabene.brown \
--to=neilb@suse.de \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).