linux-raid.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Neil Brown <neilb@suse.de>
To: Dan Williams <dan.j.williams@intel.com>
Cc: Lennert Buytenhek <buytenh@wantstofly.org>,
	Bill Davidsen <davidsen@tmr.com>,
	mingo@redhat.com, linux-raid@vger.kernel.org
Subject: Re: raid6 rebuild
Date: Wed, 11 Apr 2007 11:43:20 +1000	[thread overview]
Message-ID: <17948.15672.420527.629228@notabene.brown> (raw)
In-Reply-To: message from Dan Williams on Thursday April 5

On Thursday April 5, dan.j.williams@intel.com wrote:
> On 4/5/07, Lennert Buytenhek <buytenh@wantstofly.org> wrote:
> > On Thu, Apr 05, 2007 at 09:54:14AM -0400, Bill Davidsen wrote:
> >
> > > I confess, I would feel safer with my data if the rebuild started
> > > over, I would like to be sure that when it (finally) finishes the
> > > data are valid.
> >
> > With disk #3 about to die, I'd have felt safer if it first finished
> > rebuilding the replacement disk for failed disk #1 (that rebuild had
> > almost completed at that point), safeguarding the array against a
> > third disk failure.
> >
> I agree, the current arrangement seems to throw away a significant
> amount of work.  Yes, you will need to resync when re-adding the
> second disk, but in the meantime might as well try to get a redundant
> mode at all costs.

Yes, I think you are right.
If you want it to restart from the beginning you can alway abort the
current resync by 'echo idle > sync_action'.
The question is: is it really as simple to do as it sounds.
I seem to remember that aborting the recovery on any error was any
easy way to avoid some nasty race, but I have no idea what the race
was.
One would need the enumerate all the interesting cases and make sure
they will all work as expected.  I cannot think of an problems
immediately but that doesn't mean there aren't any...

It is now on my todo list...

NeilBrown

  reply	other threads:[~2007-04-11  1:43 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-04-04 19:46 raid6 rebuild Lennert Buytenhek
2007-04-05  3:22 ` Dan Williams
2007-04-05  5:50   ` Lennert Buytenhek
2007-04-05 13:54     ` Bill Davidsen
2007-04-05 14:06       ` Lennert Buytenhek
2007-04-05 16:59         ` Dan Williams
2007-04-11  1:43           ` Neil Brown [this message]
2007-04-05  6:03 ` Gordon Henderson
2007-04-05  6:21   ` Lennert Buytenhek
2007-04-05  8:15     ` Gordon Henderson
2007-04-05  8:48       ` Lennert Buytenhek
2007-04-05 10:13 ` Andre Noll

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=17948.15672.420527.629228@notabene.brown \
    --to=neilb@suse.de \
    --cc=buytenh@wantstofly.org \
    --cc=dan.j.williams@intel.com \
    --cc=davidsen@tmr.com \
    --cc=linux-raid@vger.kernel.org \
    --cc=mingo@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).