Re: spare group

[Neil Brown <neilb@suse.de>]

On Tuesday June 12, tomka@avaxio.net wrote:
> 
> I am very sorry, but it wont works with .9 superblocks also :( We 
> missing something small, but important here. Before you start to code. 
> mdadm was running in monitor mode, and reported a Fail. mdadm is the 
> latest version, 2.6.2.
> 
> tg

Hmmm..... 
[tests code]

Yes, you are right.  It looks like a bug was introduced in 2.6 which
broke various aspects of --monitor.  I guess I need to add some
--monitor tests to my regression test suite.

This patch should fix it.

Thanks again,
NeilBrown


-------------------------------
Fix spare migration and other problems with --monitor.

2.6 broke --monitor in various ways, including spare migration
stopped working.  This fixes it.


### Diffstat output
 ./Monitor.c |    1 +
 1 file changed, 1 insertion(+)

diff .prev/Monitor.c ./Monitor.c
--- .prev/Monitor.c	2007-02-22 14:59:11.000000000 +1100
+++ ./Monitor.c	2007-06-12 19:48:34.000000000 +1000
@@ -328,6 +328,7 @@ int Monitor(mddev_dev_t devlist,
 			for (i=0; i<MaxDisks && i <= array.raid_disks + array.nr_disks;
 			     i++) {
 				mdu_disk_info_t disc;
+				disc.number = i;
 				if (ioctl(fd, GET_DISK_INFO, &disc) >= 0) {
 					info[i].state = disc.state;
 					info[i].major = disc.major;