From: Neil Brown <neilb@suse.de>
To: Dan Williams <dan.j.williams@intel.com>
Cc: NeilBrown <neilb@suse.de>,
Andrew Morton <akpm@linux-foundation.org>,
linux-raid@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@kernel.org
Subject: Re: [PATCH] md: Fix data corruption when a degraded raid5 array is reshaped.
Date: Fri, 4 Jan 2008 11:41:55 +1100 [thread overview]
Message-ID: <18301.32979.409077.527576@notabene.brown> (raw)
In-Reply-To: message from Dan Williams on Thursday January 3
On Thursday January 3, dan.j.williams@intel.com wrote:
>
> On closer look the safer test is:
>
> !test_bit(STRIPE_OP_COMPUTE_BLK, &sh->ops.pending).
>
> The 'req_compute' field only indicates that a 'compute_block' operation
> was requested during this pass through handle_stripe so that we can
> issue a linked chain of asynchronous operations.
>
> ---
>
> From: Neil Brown <neilb@suse.de>
Technically that should probably be
From: Dan Williams <dan.j.williams@intel.com>
now, and then I add
Acked-by: NeilBrown <neilb@suse.de>
because I completely agree with your improvement.
We should keep an eye out for then Andrew commits this and make sure
the right patch goes in...
Thanks,
NeilBrown
prev parent reply other threads:[~2008-01-04 0:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20080104094516.19216.patches@notabene>
2008-01-03 22:46 ` [PATCH] md: Fix data corruption when a degraded raid5 array is reshaped NeilBrown
2008-01-03 23:00 ` Dan Williams
2008-01-03 23:40 ` Dan Williams
2008-01-04 0:41 ` Neil Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18301.32979.409077.527576@notabene.brown \
--to=neilb@suse.de \
--cc=akpm@linux-foundation.org \
--cc=dan.j.williams@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).