From: Neil Brown <neilb@suse.de>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: mangoo@wpkg.org, linux-raid@vger.kernel.org,
linux-kernel@vger.kernel.org, balajirrao@gmail.com
Subject: Re: sysfs Kernel BUG when RAID bitmap file has IO errors
Date: Fri, 14 Mar 2008 15:34:48 +1100 [thread overview]
Message-ID: <18394.104.595461.995367@notabene.brown> (raw)
In-Reply-To: message from Andrew Morton on Wednesday March 12
On Wednesday March 12, akpm@linux-foundation.org wrote:
> On Wed, 12 Mar 2008 15:36:18 -0700
> Andrew Morton <akpm@linux-foundation.org> wrote:
>
> > I assume this is the BUG_ON(count >= (ssize_t)PAGE_SIZE) in
> > fill_read_buffer().
That's a new "BUG_ON".
Before commit 8118a859dc7abd873193986c77a8d9bdb877adc8
it was
BUG_ON(count > (ssize_t)PAGE_SIZE);
But I've been looking for an excuse to remove the "super" file from
sysfs for a while.
It doesn't really fit the sysfs model, and now clearly breaks it. And
it isn't really all that useful (you can just read from the raw device
if you want to see the superblock.
It was a "seems like a good idea at the time" thing which I now
regret.
So: I'll just remove it. (with apologies to anyone who actually uses
it, but I suspect there are only two of you :-)
Patch to follow
NeilBrown
prev parent reply other threads:[~2008-03-14 4:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-12 9:40 sysfs Kernel BUG when RAID bitmap file has IO errors Tomasz Chmielewski
2008-03-12 9:51 ` Tomasz Chmielewski
2008-03-12 22:36 ` Andrew Morton
2008-03-12 22:43 ` Andrew Morton
2008-03-14 4:34 ` Neil Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18394.104.595461.995367@notabene.brown \
--to=neilb@suse.de \
--cc=akpm@linux-foundation.org \
--cc=balajirrao@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=mangoo@wpkg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).