From: Neil Brown <neilb@suse.de>
To: Chris Webb <chris@arachsys.com>
Cc: Neil Brown <neilb@suse.de>, linux-raid@vger.kernel.org
Subject: Re: Trouble increasing md component size
Date: Tue, 24 Jun 2008 08:53:18 +1000 [thread overview]
Message-ID: <18528.10590.221031.75420@notabene.brown> (raw)
In-Reply-To: message from Chris Webb on Monday June 23
On Monday June 23, chris@arachsys.com wrote:
> Hi Neil. Thanks for your advice on this patch.
And thank you for fixing it up. It looks good.
I'll try to give is a proper review and do some testing myself in a
few days.
I'm a bit bothered about the code for leaving space for a bitmap for a
1.0 array. I'd rather avoid too much of this sort of 'policy' in the
kernel. We could just leave it out and expect user-space to write a
size that leaves room for a bitmap if that is needed, but maybe that
is going too far the other way.
I thought of just scaling the "space between end of data and start of
metadata" by the same amount that the device is scaled, rounding up to
the next sector. That feels "right" if it doesn't turn out to be too
clumsy.
Also, you add 4 lines greater than 80 columns :-) if you run
./scripts/checkpatch.pl name-of-patch-file
it will tell you these things.
NeilBrown
next prev parent reply other threads:[~2008-06-23 22:53 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-18 18:26 Trouble increasing md component size Chris Webb
2008-06-18 19:22 ` Peter Rabbitson
2008-06-18 20:00 ` Chris Webb
2008-06-19 3:42 ` Neil Brown
2008-06-19 15:45 ` Chris Webb
2008-06-19 23:10 ` Chris Webb
2008-06-19 23:49 ` Chris Webb
2008-06-20 11:13 ` Chris Webb
2008-06-20 14:24 ` Chris Webb
2008-06-23 1:26 ` Neil Brown
2008-06-23 11:18 ` Chris Webb
2008-06-23 22:53 ` Neil Brown [this message]
2008-06-24 11:47 ` Chris Webb
2008-06-24 23:19 ` Chris Webb
2008-09-17 18:11 ` [PATCH] md: Fix rdev_size_store with size = 0 Chris Webb
2008-10-07 12:40 ` [Resend] " Chris Webb
2008-10-13 0:54 ` Neil Brown
2008-06-24 2:40 ` Trouble increasing md component size Neil Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18528.10590.221031.75420@notabene.brown \
--to=neilb@suse.de \
--cc=chris@arachsys.com \
--cc=linux-raid@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).