From: Neil Brown <neilb@suse.de>
To: Dan Williams <dan.j.williams@intel.com>
Cc: linux-raid <linux-raid@vger.kernel.org>
Subject: Re: [mdadm git pull] "--assemble --scan" support for imsm
Date: Tue, 4 Nov 2008 21:52:12 +1100 [thread overview]
Message-ID: <18704.10588.526784.38341@notabene.brown> (raw)
In-Reply-To: message from Dan Williams on Sunday November 2
On Sunday November 2, dan.j.williams@intel.com wrote:
> On Wed, 2008-10-29 at 20:42 -0700, Neil Brown wrote:
> > To fit the assembly of a specific member of a container into this
> > model, we need to have the 'container' in the list of available
> > devices.
> > If the identity specifies 'container=whatever' then we clearly select
> > all devices which match that. You would expect at exactly one - the
> > container. You would then need to call ->container_content on that
> > container and find the correct member array which matches the
> > 'member=' specifier (or any other specifier there might be?)
> >
> > Exactly how updates and "--force" are passed though would need to be
> > sorted out.
> > Then the devices in the selected array from ->container_content could
> > be passed to sysfs_add_disk and the array started.
> >
> > Auto-assembly would discover that the first unused-so-far device was a
> > container, and would need to load the list of arrays and assemble the
> > first one that was not yet assembled.
> >
>
> I had a go at this, and the result is pushed out to my scratch-devel
> branch.
Thanks. I took your code, kept some bits, fixed some bits, rewrote
other bits and completely replaced some more :-) And added some of my
code too.
I've just pushed the result to my devel-3.0 branch
git pull git://neil.brown.name/mdadm devel-3.0
It get a clean "make everything" and the self tests all run (I hope -
it's late and I cannot wait for the final run).
Tomorrow I'm going to hack at the man page, and write some more test
scripts.
With the current code
mdadm -As
should find and assemble all of your arrays. And give fairly useful
names.
I haven't included your
Let symlinks to standard devices count as standard names
patch because I don't think I agree with it, and I don't think it is
needed any more.
I also have left out your
imsm: match_home(), document why it is stubbed out
because I don't understand. Maybe some more words about how
'family_num' can distinguish between "Local" and "Foreign". ??
Thanks heaps,
NeilBrown
next prev parent reply other threads:[~2008-11-04 10:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-28 21:44 [mdadm git pull] "--assemble --scan" support for imsm Dan Williams
2008-10-29 9:19 ` Neil Brown
2008-10-29 16:12 ` Dan Williams
2008-10-30 3:42 ` Neil Brown
2008-11-02 23:15 ` Dan Williams
2008-11-04 10:52 ` Neil Brown [this message]
2008-11-05 15:40 ` Dan Williams
2008-10-30 12:43 ` Neil Brown
[not found] <4C69D525.4060404@gmail.com>
2010-08-17 16:49 ` Dan Williams
2010-08-17 18:48 ` Jiang, Dave
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18704.10588.526784.38341@notabene.brown \
--to=neilb@suse.de \
--cc=dan.j.williams@intel.com \
--cc=linux-raid@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).