linux-raid.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Neil Brown <neilb@suse.de>
To: Jon Nelson <jnelson-linux-raid@jamponi.net>,
	LinuxRaid <linux-raid@vger.kernel.org>
Subject: Re: weird issues with raid1
Date: Thu, 18 Dec 2008 16:43:05 +1100	[thread overview]
Message-ID: <18761.58089.682224.315110@notabene.brown> (raw)
In-Reply-To: message from Neil Brown on Monday December 15

On Monday December 15, neilb@suse.de wrote:
> > 
> > No matter how long I wait, until it is rebuilt, the bitmap on /dev/sda
> > is always 100% dirty.
> > If I --fail, --remove (twice) /dev/sda, and I re-add /dev/sdd1, it
> > clearly uses the bitmap and re-syncs in under 1 second.
> 
> Yes, there is a bug here.
> When an array recovers on to a hot space it doesn't copy the bitmap
> across.  That will only happen lazily as bits are updated.
> I'm surprised I hadn't noticed that before, so they might be more to
> this than I'm seeing at the moment.   But I definitely cannot find
> code to copy the bitmap across.  I'll have to have a think about
> that. 

There isn't a bug here, I was wrong.

We don't update the bitmap on recovery until the recovery is
complete.  Once it is complete we do (as you notice) update it all at
once.
This is correct behaviour because until the recovery is complete, the
new device isn't really part of the array so the bitmap on it doesn't
mean anything.  As soon as the array is flagged as 'InSync' we update
the bitmap on it.

NeilBrown

  parent reply	other threads:[~2008-12-18  5:43 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-06  2:10 weird issues with raid1 Jon Nelson
2008-12-06  2:46 ` Jon Nelson
2008-12-06 12:16   ` Justin Piszcz
2008-12-15  2:17     ` Jon Nelson
2008-12-15  6:00 ` Neil Brown
2008-12-15 13:42   ` Jon Nelson
2008-12-15 21:33     ` Neil Brown
2008-12-15 21:47       ` Jon Nelson
2008-12-16  1:21         ` Neil Brown
2008-12-16  2:32           ` Jon Nelson
2008-12-18  4:42           ` Neil Brown
2008-12-18  4:50             ` Jon Nelson
2008-12-18  4:55               ` Jon Nelson
2008-12-18  5:17                 ` Neil Brown
2008-12-18  5:47                   ` Jon Nelson
2008-12-18  6:21                     ` Neil Brown
2008-12-19  2:15                       ` Jon Nelson
2008-12-19 16:51                         ` Jon Nelson
2008-12-19 20:40                           ` Jon Nelson
2008-12-19 21:18                             ` Jon Nelson
2008-12-22 14:40                               ` Jon Nelson
2008-12-22 21:07                                 ` NeilBrown
2008-12-18  5:43   ` Neil Brown [this message]
2008-12-18  5:54     ` Jon Nelson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=18761.58089.682224.315110@notabene.brown \
    --to=neilb@suse.de \
    --cc=jnelson-linux-raid@jamponi.net \
    --cc=linux-raid@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).