linux-raid.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Neil Brown <neilb@suse.de>
To: Dan Williams <dan.j.williams@intel.com>
Cc: linux-raid <linux-raid@vger.kernel.org>,
	ed.ciechanowski@intel.com, jacek.danecki@intel.com
Subject: Re: [PATCH] md: 'size_limit' attribute
Date: Sat, 14 Feb 2009 14:20:10 +1100	[thread overview]
Message-ID: <18838.14442.891790.33471@notabene.brown> (raw)
In-Reply-To: message from Dan Williams on Friday February 13

On Friday February 13, dan.j.williams@intel.com wrote:
> Subject: md: 'size_limit' attribute
> From: Dan Williams <dan.j.williams@intel.com>
> 
> Provide a sysfs attribute to allow a raid array to be truncated to an
> arbitrary size.  This functionality is needed to support imsm raid
> arrays where the metadata format expects that the size of some arrays is
> rounded down to the nearest 1MB boundary.

Well it's not April 1st, so I assume you are serious.

It really truncates the array, not the individual drives?
So you could have e.g. a raid0 in which only some of the last stripe
was used?

Can you give me a concrete example of an array where this will make a
required difference?  I just want to be sure I understand.

I guess you couldn't just add an 'array_size' attribute which gave
direct access to mddev->array_size because that gets set when the
array is started, and we want to be able to impose the limit before
starting the array....

How about a semantic where starting the array will only modify
->array_size if it's value is zero of if it would reduce the value.

How might this interact with array resizing?  You add a drive to an
array, reshape it, and then it doesn't get any bigger until the
size_limit is updated?   I guess that could work but it might be
confusing.... though presumably mdadm/mdmon would know to look after
all the details. 


What would you think of renaming the attribute to 'array_size' with
the semantic of "once user-space sets it, the kernel will never change
it" ??

NeilBrown

  reply	other threads:[~2009-02-14  3:20 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-13 18:30 [PATCH] md: 'size_limit' attribute Dan Williams
2009-02-14  3:20 ` Neil Brown [this message]
2009-02-18  0:06   ` Dan Williams
2009-02-20  4:07     ` Neil Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=18838.14442.891790.33471@notabene.brown \
    --to=neilb@suse.de \
    --cc=dan.j.williams@intel.com \
    --cc=ed.ciechanowski@intel.com \
    --cc=jacek.danecki@intel.com \
    --cc=linux-raid@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).