From: Neil Brown <neilb@suse.de>
To: Dan Williams <dan.j.williams@intel.com>
Cc: linux-raid@vger.kernel.org, ed.ciechanowski@intel.com,
jacek.danecki@intel.com
Subject: Re: [PATCH 2.6.29-rc7] md: fix deadlock when stopping arrays
Date: Fri, 6 Mar 2009 16:27:46 +1100 [thread overview]
Message-ID: <18864.46162.353471.534054@notabene.brown> (raw)
In-Reply-To: message from Dan Williams on Thursday March 5
On Thursday March 5, dan.j.williams@intel.com wrote:
> Resolve a deadlock when stopping redundant arrays, i.e. ones that
> require a call to sysfs_remove_group when shutdown. The deadlock is
> summarized below:
>
> Thread1 Thread2
> ------- -------
> read sysfs attribute stop array
> take mddev lock
> sysfs_remove_group
> sysfs_get_active
> wait for mddev lock
> wait for active
Thanks.
It's pretty sneaking overloading ->private to let mddev_delayed_delete
know that it has something else to do ... wish I'd thought of it :-)
Can you add
Cc: stable@kernel.org
at the bottom. Then I'll pull it and send a pull request to Linus. I
think it should go straight in.
[If a commit contains "cc: stable@kernel.org" then the "stable team"
will automatically notice it as soon as Linus pulls it - no need to
bother them with extra email.]
Thanks.
NeilBrown
next prev parent reply other threads:[~2009-03-06 5:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-05 23:07 [PATCH 2.6.29-rc7] md: fix deadlock when stopping arrays Dan Williams
2009-03-06 5:27 ` Neil Brown [this message]
2009-03-06 22:20 ` Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18864.46162.353471.534054@notabene.brown \
--to=neilb@suse.de \
--cc=dan.j.williams@intel.com \
--cc=ed.ciechanowski@intel.com \
--cc=jacek.danecki@intel.com \
--cc=linux-raid@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).