From: Neil Brown <neilb@suse.de>
To: Andre Noll <maan@systemlinux.org>
Cc: linux-raid@vger.kernel.org
Subject: Re: [PATCH] md: raid5 run(): Fix max_degraded for raid level 4.
Date: Fri, 20 Mar 2009 11:09:30 +1100 [thread overview]
Message-ID: <18882.57018.465098.201167@notabene.brown> (raw)
In-Reply-To: message from Andre Noll on Wednesday March 18
On Wednesday March 18, maan@systemlinux.org wrote:
> Hi Neil,
>
> I found this one while trying to figure out why 3-disk raid6 arrays
> aren't supported. It's an obvious and trivial bug fix but probably
> not important enough for stable as it only affects raid4.
>
Thanks!
Applied.
Have you tried a 3-disk raid6 yet? Any conclusions?
NeilBrown
> Regards
> Andre
>
> commit ea30abef4d1f3aad635eb24db082f3531b573540
> Author: Andre Noll <maan@systemlinux.org>
> Date: Wed Mar 18 13:43:08 2009 +0100
>
> md: raid5 run(): Fix max_degraded for raid level 4.
>
> raid4 allows only one failed disk.
>
> Signed-off-by: Andre Noll <maan@systemlinux.org>
>
> diff --git a/drivers/md/raid5.c b/drivers/md/raid5.c
> index a76ef52..ceb5924 100644
> --- a/drivers/md/raid5.c
> +++ b/drivers/md/raid5.c
> @@ -4484,7 +4484,7 @@ static int run(mddev_t *mddev)
> */
> sector_t here_new, here_old;
> int old_disks;
> - int max_degraded = (mddev->level == 5 ? 1 : 2);
> + int max_degraded = (mddev->level == 6 ? 2 : 1);
>
> if (mddev->new_level != mddev->level ||
> mddev->new_layout != mddev->layout ||
> --
> The only person who always got his work done by Friday was Robinson Crusoe
next prev parent reply other threads:[~2009-03-20 0:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-18 12:53 [PATCH] md: raid5 run(): Fix max_degraded for raid level 4 Andre Noll
2009-03-20 0:09 ` Neil Brown [this message]
2009-03-20 9:14 ` [PATCH] relax checks to support 3disk raid6 arrays Andre Noll
2009-03-20 9:20 ` Peter Rabbitson
2009-03-20 9:29 ` Andre Noll
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18882.57018.465098.201167@notabene.brown \
--to=neilb@suse.de \
--cc=linux-raid@vger.kernel.org \
--cc=maan@systemlinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).