From: Neil Brown <neilb@suse.de>
To: raz ben yehuda <raziebe@gmail.com>
Cc: linux raid <linux-raid@vger.kernel.org>, yaronp@bitband.com
Subject: Re: Subject : [ md PATCHE 5/6] : 1K *n chunks.
Date: Tue, 19 May 2009 10:48:50 +1000 [thread overview]
Message-ID: <18962.498.101162.146118@notabene.brown> (raw)
In-Reply-To: message from raz ben yehuda on Tuesday May 19
On Tuesday May 19, raziebe@gmail.com wrote:
> md to support 1K*n chunks only in the case of raid 0
> Signed-off-by: raziebe@gmail.com
> ---
> diff --git a/drivers/md/md.c b/drivers/md/md.c
> index aab183e..75a3634 100644
> --- a/drivers/md/md.c
> +++ b/drivers/md/md.c
> @@ -4011,9 +4011,9 @@ static int do_md_run(mddev_t * mddev)
> return -EINVAL;
> }
> /*
> - * raid0 chunk size has to divide by a page
> + * raid0 chunk size has to divide by a 1K
> */
> - if (mddev->level == 0 && (chunk_size % PAGE_SIZE)) {
> + if (mddev->level == 0 && (chunk_size % 1024)) {
> printk(KERN_ERR "chunk_size of %d not valid\n",
> chunk_size);
> return -EINVAL;
>
Ah... 1K is the minimum now. I cannot see why this is a separate
patch, or why 1K is an appropriate limit.
NeilBrown
next prev parent reply other threads:[~2009-05-19 0:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-18 23:08 Subject : [ md PATCHE 5/6] : 1K *n chunks raz ben yehuda
2009-05-19 0:48 ` Neil Brown [this message]
2009-05-19 13:21 ` raz ben yehuda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18962.498.101162.146118@notabene.brown \
--to=neilb@suse.de \
--cc=linux-raid@vger.kernel.org \
--cc=raziebe@gmail.com \
--cc=yaronp@bitband.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).