From: Neil Brown <neilb@suse.de>
To: Dan Williams <dan.j.williams@intel.com>
Cc: linux-raid@vger.kernel.org, Ilya Yanok <yanok@emcraft.com>,
Yuri Tikhonov <yur@emcraft.com>
Subject: Re: [PATCH v2 7/9] md/raid6: asynchronous handle_stripe6
Date: Tue, 15 Sep 2009 15:26:16 +1000 [thread overview]
Message-ID: <19119.9592.91030.892183@notabene.brown> (raw)
In-Reply-To: message from Dan Williams on Monday August 31
Sorry for the long delay in getting to these. I week's leave recently
and that always causes tasks to pile up....
I am happy for this to all go in this merge window. I just have a
few nits I would like to see changed then I'll pull and push to Linus.
in this patch:
> /* now count some things */
> if (test_bit(R5_LOCKED, &dev->flags)) s.locked++;
> if (test_bit(R5_UPTODATE, &dev->flags)) s.uptodate++;
> + if (test_bit(R5_Wantcompute, &dev->flags))
> + BUG_ON(++s.compute > 2);
I think having a side-effect in a BUG_ON is very poor form. I should
be able to recompile the code with BUG_ON() becoming a no-op and
everything should still work.
So something like:
> + if (test_bit(R5_Wantcompute, &dev->flags)) {
> + ++s.compute;
> + BUG_ON(s.compute > 2);
> + }
please.
NeilBrown
next prev parent reply other threads:[~2009-09-15 5:26 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-31 16:41 [PATCH v2 0/9] Asynchronous raid6 acceleration (part 3 of 3) Dan Williams
2009-08-31 16:41 ` [PATCH v2 1/9] md/raid5: factor out mark_uptodate from ops_complete_compute5 Dan Williams
2009-08-31 16:41 ` [PATCH v2 2/9] md/raid6: asynchronous raid6 operations Dan Williams
2009-09-15 5:32 ` Neil Brown
2009-08-31 16:41 ` [PATCH v2 3/9] md/raid5, 6: common schedule_reconstruction for raid5/6 Dan Williams
2009-08-31 16:41 ` [PATCH v2 4/9] md/raid6: asynchronous handle_stripe_fill6 Dan Williams
2009-08-31 16:41 ` [PATCH v2 5/9] md/raid6: asynchronous handle_stripe_dirtying6 Dan Williams
2009-08-31 16:41 ` [PATCH v2 6/9] md/raid6: asynchronous handle_parity_check6 Dan Williams
2009-08-31 16:41 ` [PATCH v2 7/9] md/raid6: asynchronous handle_stripe6 Dan Williams
2009-09-15 5:26 ` Neil Brown [this message]
2009-09-15 8:42 ` Dan Williams
2009-08-31 16:41 ` [PATCH v2 8/9] md/raid6: remove synchronous infrastructure Dan Williams
2009-08-31 16:41 ` [PATCH v2 9/9] md/raid456: distribute raid processing over multiple cores Dan Williams
2009-08-31 17:23 ` [PATCH v2 0/9] Asynchronous raid6 acceleration (part 3 of 3) kwick
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=19119.9592.91030.892183@notabene.brown \
--to=neilb@suse.de \
--cc=dan.j.williams@intel.com \
--cc=linux-raid@vger.kernel.org \
--cc=yanok@emcraft.com \
--cc=yur@emcraft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).