linux-raid.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Neil Brown <neilb@suse.de>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: linux-raid@vger.kernel.org
Subject: [PULL REQUEST] md bug fix relating to merge_bvec_fn
Date: Tue, 16 Mar 2010 17:11:26 +1100	[thread overview]
Message-ID: <19359.8462.660720.717447@notabene.brown> (raw)


When an md device stacks on top of a device which defines a
merge_bvec_fn, the md device must either call that function to check
that bios aren't created which are 'too big' (often a difficult thing
to do) or must ensure the bios never have more than a single page.

It came up in a recent discussion on dm-devel that the current
approach of limiting a request to PAGE_SIZE is not sufficient as you
could have several sub-page buffers.

So this patch changes to the use max_segments and
segment_boundary_mask to ensure there is only a single page - or part
there of - in a bio if an underlying device has a merge_bvec_fn.

This can affect 'xen' installations particularly.

This patch is tagged for -stable.

Thanks,
NeilBrown


The following changes since commit 25cf84cf377c0aae5dbcf937ea89bc7893db5176:
  Linus Torvalds (1):
        Merge git://git.kernel.org/.../amit/virtio-console

are available in the git repository at:

  git://neil.brown.name/md/ for-linus

NeilBrown (1):
      md: deal with merge_bvec_fn in component devices better.

 drivers/md/linear.c    |   12 +++++++-----
 drivers/md/multipath.c |   20 ++++++++++++--------
 drivers/md/raid0.c     |   13 +++++++------
 drivers/md/raid1.c     |   28 +++++++++++++++++-----------
 drivers/md/raid10.c    |   28 +++++++++++++++++-----------
 5 files changed, 60 insertions(+), 41 deletions(-)

                 reply	other threads:[~2010-03-16  6:11 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=19359.8462.660720.717447@notabene.brown \
    --to=neilb@suse.de \
    --cc=linux-raid@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).