Linux RAID subsystem development
 help / color / mirror / Atom feed
From: "Tkaczyk, Mariusz" <mariusz.tkaczyk@linux.intel.com>
To: Nigel Croxon <ncroxon@redhat.com>,
	linux-raid <linux-raid@vger.kernel.org>
Subject: Re: [PATCH V3] Fix buffer size warning for strcpy
Date: Mon, 23 Aug 2021 17:36:31 +0200	[thread overview]
Message-ID: <1c777af7-dda5-4332-74d0-0d4e1ba58031@linux.intel.com> (raw)
In-Reply-To: <20210823143525.2517040-1-ncroxon@redhat.com>

On 23.08.2021 16:35, Nigel Croxon wrote:
> To meet requirements of Common Criteria certification vulnerability
> assessment. Static code analysis has been run and found the following
> error:
> buffer_size_warning: Calling "strncpy" with a maximum size
> argument of 16 bytes on destination array "ve->name" of
> size 16 bytes might leave the destination string unterminated.
> 

Yeah, please ignore my comment to v2- the task here it remove error, not
to acknowledge it.

> +		int l = strlen(ve->name);
> +		if (l > 16)
> +			l = 16;
I think that whole "if" statement can be replaced by:
strnlen(ve->name, sizeof(ve->name))
> +		memcpy(ve->name, name, l);
> +	}


  reply	other threads:[~2021-08-23 15:36 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-23 14:35 [PATCH V3] Fix buffer size warning for strcpy Nigel Croxon
2021-08-23 15:36 ` Tkaczyk, Mariusz [this message]
2021-08-24  7:35   ` Tkaczyk, Mariusz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1c777af7-dda5-4332-74d0-0d4e1ba58031@linux.intel.com \
    --to=mariusz.tkaczyk@linux.intel.com \
    --cc=linux-raid@vger.kernel.org \
    --cc=ncroxon@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox