Linux RAID subsystem development
 help / color / mirror / Atom feed
From: Luca Berra <bluca@comedia.it>
To: SoulBlazer <soul@lamp-post.net>
Cc: linux-raid@vger.kernel.org
Subject: Re: 2 HBA's and Multipath.
Date: Fri, 19 Apr 2002 23:58:43 +0200	[thread overview]
Message-ID: <20020419215843.GB21753@colombina.comedia.it> (raw)
In-Reply-To: <20020419162031Z312453-22651+11469@vger.kernel.org>

On Fri, Apr 19, 2002 at 12:18:11PM -0400, SoulBlazer wrote:
> Well I applied those modifications however I am noticing the following :
> 
> --BEGIN SNIPPIT--
> 
> # : mdadm -D /dev/md/1
> /dev/md/1:
>         Version : 00.90.00
>   Creation Time : Fri Apr 19 12:14:13 2002
>      Raid Level : multipath
>      Array Size : 17688448 (16.86 GiB 18.11 GB)
>    Raid Devices : 1
>   Total Devices : 2
> Preferred Minor : 1
>     Persistence : Superblock is persistent
> 
>     Update Time : Fri Apr 19 12:14:13 2002
>           State : dirty, no-errors
>  Active Devices : 1
> Working Devices : 2
>  Failed Devices : 0
>   Spare Devices : 1
> 
>     Number   Major   Minor   RaidDevice State
>        0      65      113        0      active sync   
> /dev/scsi/host3/bus0/target1/lun0/part1
>        1       8       17        1        
> /dev/scsi/host2/bus0/target1/lun0/part1
> 

Oops,
seems i forgot about spares :(

multipath.c sets all disks as spares to start with.
a dirty hack could be:

look for:
        /*
         * Mark all disks as spare to start with, then pick our
         * active disk.  If we have a disk that is marked active
         * in the sb, then use it, else use the first rdev.
         */

below you will find:
       if (disk_active(desc)) {
            if(!conf->working_disks) { //remove this line
                printk(OPERATIONAL, partition_name(rdev->dev),
                    desc->raid_disk);
                disk->operational = 1;
                disk->spare = 0;
                conf->working_disks++;
                def_rdev = rdev;
            } else { //remove this line
                mark_disk_spare(desc); //remove this line
            } //remove this line
        } else
            mark_disk_spare(desc);

remove the lines i market with //remove this line
and it should activate the disks

i wont have a system at hand to test this, so please let me know
if it works

we then need to clean up the logic for initialization
since is nonsense to set a disk as spare then reset it back
again as operational, but this could work for a start

good luck

L.

-- 
Luca Berra -- bluca@comedia.it
        Communication Media & Services S.r.l.
 /"\
 \ /     ASCII RIBBON CAMPAIGN
  X        AGAINST HTML MAIL
 / \

  parent reply	other threads:[~2002-04-19 21:58 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-04-08 19:02 2 HBA's and Multipath SoulBlazer
2002-04-08 19:16 ` Luca Berra
2002-04-08 20:03   ` SoulBlazer
2002-04-11  9:49     ` Luca Berra
2002-04-19 16:18       ` SoulBlazer
2002-04-19 18:28         ` SoulBlazer
2002-04-19 21:58         ` Luca Berra [this message]
2002-04-23 21:45           ` SoulBlazer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20020419215843.GB21753@colombina.comedia.it \
    --to=bluca@comedia.it \
    --cc=linux-raid@vger.kernel.org \
    --cc=soul@lamp-post.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox