linux-raid.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Lars Marowsky-Bree <lmb@suse.de>
To: linux-raid@vger.kernel.org, Neil Brown <neilb@cse.unsw.edu.au>
Cc: axboe@suse.de
Subject: Locking bugs in 2.4 md.c
Date: Thu, 18 Sep 2003 17:23:10 +0200	[thread overview]
Message-ID: <20030918152310.GD30852@marowsky-bree.de> (raw)

Hi Neil,

I can pretty reliably Oops the 2.4 md raid1 in md_update_sb with a

while true
	mdadm /dev/md0 -f /dev/foo -r /dev/foo
	mdadm /dev/md0 -a /dev/foo
done &
while true
	mdadm /dev/md1 -f /dev/bar -r /dev/bar
	mdadm /dev/md1 -a /dev/bar
done &

in parallel on several md devices. It will finally die in md_update_sb,
and appears to be related to some locking bugs.

(The above is a stress test and makes it occur faster; customers report
it happens in the field too, that's why I went looking.)

In March (see http://www.spinics.net/lists/raid/msg02335.html) you wrote
you had a patch which made the locking in 2.4 "better", even though it
was rather ugly. Well, ugly it might be, but needed still ;-)

I assume you want to use the reconfig_sem for it? If you don't have a
recent patch, could you sketch out what you wanted to do so I could
start from there?

Thanks!


Sincerely,
    Lars Marowsky-Brée <lmb@suse.de>

(Or maybe you want to backport the 2.6 md to 2.4... ;-)

-- 
High Availability & Clustering		ever tried. ever failed. no matter.
SuSE Labs				try again. fail again. fail better.
Research & Development, SuSE Linux AG		-- Samuel Beckett

-
To unsubscribe from this list: send the line "unsubscribe linux-raid" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

             reply	other threads:[~2003-09-18 15:23 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-09-18 15:23 Lars Marowsky-Bree [this message]
2003-09-19  2:08 ` Locking bugs in 2.4 md.c Neil Brown
2003-09-19  7:26   ` Lars Marowsky-Bree
2003-09-19  8:36     ` Lars Marowsky-Bree
2003-09-19 14:18       ` Lars Marowsky-Bree
2003-09-22  5:54       ` Neil Brown
2003-09-23 11:08         ` Lars Marowsky-Bree
2003-09-24 10:31   ` [fixes] " Lars Marowsky-Bree

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030918152310.GD30852@marowsky-bree.de \
    --to=lmb@suse.de \
    --cc=axboe@suse.de \
    --cc=linux-raid@vger.kernel.org \
    --cc=neilb@cse.unsw.edu.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).