From: Andrew Morton <akpm@osdl.org>
To: NeilBrown <neilb@cse.unsw.edu.au>
Cc: linux-raid@vger.kernel.org
Subject: Re: [PATCH] md - 1 of 2 - Use "shedule_timeout(2)" instead of yield() as it seems to wait for less time.
Date: Thu, 4 Mar 2004 22:16:21 -0800 [thread overview]
Message-ID: <20040304221621.47dd459f.akpm@osdl.org> (raw)
In-Reply-To: <E1Az89R-0001su-00@notabene>
NeilBrown <neilb@cse.unsw.edu.au> wrote:
>
> + schedule_timeout(2);
Are you sure we want to sleep for 20-30 milliseconds on a 100 Hz machine?
Wouldn't it be better to do
diff -puN drivers/md/raid5.c~md-use-schedule_timeout drivers/md/raid5.c
--- 25/drivers/md/raid5.c~md-use-schedule_timeout 2004-03-04 22:15:14.000000000 -0800
+++ 25-akpm/drivers/md/raid5.c 2004-03-04 22:15:41.000000000 -0800
@@ -1409,7 +1409,8 @@ static int sync_request (mddev_t *mddev,
/* make sure we don't swamp the stripe cache if someone else
* is trying to get access
*/
- yield();
+ set_current_state(TASK_UNINTERRUPTIBLE);
+ schedule_timeout(max(HZ/500, 1));
}
spin_lock(&sh->lock);
set_bit(STRIPE_SYNCING, &sh->state);
diff -puN drivers/md/raid6main.c~md-use-schedule_timeout drivers/md/raid6main.c
--- 25/drivers/md/raid6main.c~md-use-schedule_timeout 2004-03-04 22:15:14.000000000 -0800
+++ 25-akpm/drivers/md/raid6main.c 2004-03-04 22:15:50.000000000 -0800
@@ -1571,7 +1571,8 @@ static int sync_request (mddev_t *mddev,
/* make sure we don't swamp the stripe cache if someone else
* is trying to get access
*/
- yield();
+ set_current_state(TASK_UNINTERRUPTIBLE);
+ schedule_timeout(max(HZ/500, 1));
}
spin_lock(&sh->lock);
set_bit(STRIPE_SYNCING, &sh->state);
_
?
next prev parent reply other threads:[~2004-03-05 6:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-03-05 5:45 [PATCH] md - 0 of 2 - Introduction NeilBrown
2004-03-05 5:45 ` [PATCH] md - 1 of 2 - Use "shedule_timeout(2)" instead of yield() as it seems to wait for less time NeilBrown
2004-03-05 6:16 ` Andrew Morton [this message]
2004-03-10 2:26 ` Neil Brown
2004-03-05 5:45 ` [PATCH] md - 2 of 2 - Allow assembling of partitioned arrays at boot time NeilBrown
2004-03-05 8:42 ` [PATCH] md - 0 of 2 - Introduction Clemens Schwaighofer
2004-03-05 10:01 ` Michael Tokarev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040304221621.47dd459f.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=linux-raid@vger.kernel.org \
--cc=neilb@cse.unsw.edu.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).