From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Morton <akpm@osdl.org>
Subject: Re: [PATCH md 3 of 4] Delete unplug timer before shutting down md
 array.
Date: Mon, 1 Nov 2004 21:00:44 -0800
Message-ID: <20041101210044.20c4a8e0.akpm@osdl.org>
References: <20041102143440.12019.patches@notabene>
	<E1COpUP-000392-Hw@notabene.cse.unsw.edu.au>
	<20041101205735.5fc68d69.akpm@osdl.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Return-path: <linux-raid-owner@vger.kernel.org>
In-Reply-To: <20041101205735.5fc68d69.akpm@osdl.org>
Sender: linux-raid-owner@vger.kernel.org
To: neilb@cse.unsw.edu.au, linux-raid@vger.kernel.org
List-Id: linux-raid.ids

Andrew Morton <akpm@osdl.org> wrote:
>
> NeilBrown <neilb@cse.unsw.edu.au> wrote:
> >
> > As the unplug timer can potentially fire at any time, and
> >  and it access data that is released by the md ->stop function,
> >  we need to del_timer_sync before releasing that data.
> 
> raid really shouldn't know about unplug_timer.
> 

I mean, if we're actually destroying the queue then blk_cleanup_queue()
should have done the right thing here.  If we're not destroying the queue
then an unplug timer expiry should be benign.

Bit confused as to what's happening here.