From: Andrew Morton <akpm@osdl.org>
To: NeilBrown <neilb@cse.unsw.edu.au>
Cc: linux-raid@vger.kernel.org
Subject: Re: [PATCH md 6 of 6] Fix handling of overlapping requests in raid5
Date: Mon, 7 Feb 2005 18:24:56 -0800 [thread overview]
Message-ID: <20050207182456.1d50c83b.akpm@osdl.org> (raw)
In-Reply-To: <E1Cxyst-0004fu-PP@notabene.cse.unsw.edu.au>
NeilBrown <neilb@cse.unsw.edu.au> wrote:
>
> + retry:
> sh = get_active_stripe(conf, new_sector, pd_idx, (bi->bi_rw&RWA_MASK));
> if (sh) {
> -
> - while (!add_stripe_bio(sh, bi, dd_idx, (bi->bi_rw&RW_MASK))) {
> - /* add failed due to overlap. Flush everything
> + if (!add_stripe_bio(sh, bi, dd_idx, (bi->bi_rw&RW_MASK))) {
> + /* Add failed due to overlap. Flush everything
> * and wait a while
> - * FIXME - overlapping requests should be handled better
> */
> raid5_unplug_device(mddev->queue);
> - set_current_state(TASK_UNINTERRUPTIBLE);
> - schedule_timeout(1);
> + release_stripe(sh);
> + schedule();
> + goto retry;
Worrisome. If the calling process has SCHED_RR or SCHED_FIFO policy, this
could cause a lockup, perhaps.
Some sort of real synchronisation scheme would be nicer. Or at the least,
what was wrong with the schedule_timeout(1)?
next prev parent reply other threads:[~2005-02-08 2:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-02-07 2:44 [PATCH md 0 of 6] Introduction NeilBrown
2005-02-07 2:44 ` [PATCH md 3 of 6] Make md work a bit better with devfs NeilBrown
2005-02-07 2:44 ` [PATCH md 4 of 6] Fix endless loop when syncing an array that doesn't need any resync NeilBrown
2005-02-07 2:44 ` [PATCH md 2 of 6] Prevent oops when drive set faulty in inactive md array NeilBrown
2005-02-07 2:44 ` [PATCH md 5 of 6] Remove extra loop from copy_data NeilBrown
2005-02-07 2:44 ` [PATCH md 1 of 6] Fix problems with verion-1 superblock code NeilBrown
2005-02-07 2:44 ` [PATCH md 6 of 6] Fix handling of overlapping requests in raid5 NeilBrown
2005-02-08 2:24 ` Andrew Morton [this message]
2005-02-08 2:39 ` Neil Brown
2005-02-08 3:07 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050207182456.1d50c83b.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=linux-raid@vger.kernel.org \
--cc=neilb@cse.unsw.edu.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).