From: Andrew Morton <akpm@osdl.org>
To: NeilBrown <neilb@cse.unsw.edu.au>
Cc: linux-raid@vger.kernel.org
Subject: Re: [PATCH md 001 of 2] Close a small race in md thread deregistration
Date: Thu, 7 Apr 2005 19:14:21 -0700 [thread overview]
Message-ID: <20050407191421.31b26d3e.akpm@osdl.org> (raw)
In-Reply-To: <E1DJiVG-0007B6-Bd@notabene.cse.unsw.edu.au>
NeilBrown <neilb@cse.unsw.edu.au> wrote:
>
> There is a tiny race when de-registering an MD thread, in that the
> thread could disappear before it is set a SIGKILL, causing
> send_sig to have problems.
> This is most easily closed by holding tasklist_lock between
> enabling the thread to exit (setting ->run to NULL) and telling
> it to exit.
That code all seems a bit crufty to me. Sometime it would be good to stop
using signals in-kernel and to use the kthread API for thread startup and
shutdown.
next prev parent reply other threads:[~2005-04-08 2:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-04-08 1:41 [PATCH md 000 of 2] Introduction NeilBrown
2005-04-08 1:41 ` [PATCH md 001 of 2] Close a small race in md thread deregistration NeilBrown
2005-04-08 2:14 ` Andrew Morton [this message]
2005-04-08 2:20 ` Neil Brown
2005-04-08 1:41 ` [PATCH md 002 of 2] Remove a number of misleading calls to MD_BUG NeilBrown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050407191421.31b26d3e.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=linux-raid@vger.kernel.org \
--cc=neilb@cse.unsw.edu.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox