linux-raid.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Lars Marowsky-Bree <lmb@suse.de>
To: James Pearson <james-p@moving-picture.com>,
	Mike Tran <mhtran@us.ibm.com>
Cc: lnx1138@us.ibm.com, linux-raid@vger.kernel.org
Subject: Re: Oops when starting md multipath on a 2.4 kernel
Date: Thu, 14 Jul 2005 12:13:29 +0200	[thread overview]
Message-ID: <20050714101329.GI25179@marowsky-bree.de> (raw)
In-Reply-To: <42D639DC.80608@moving-picture.com>

On 2005-07-14T11:09:32, James Pearson <james-p@moving-picture.com> wrote:

> Thanks - that patch applies OK to more recent 2.4 kernels and appears to 
> 'fix' this problem.
> 
> However, if you have a cut down patch that fixes just this problem, then 
> I would appreciate it if you could make it available.

There's a bugfix needed for 2.4 md multipath which prevents guaranteed data
corruption on failover too. I don't have time to redo the diffs against
2.4 proper, but

-                       bh->b_rdev = bh->b_dev;
-                       bh->b_rsector = bh->b_blocknr;

are probably the two most important changes to multipath.c:multipathd().

The patch in the SLES8 2.4 kernel is
patches.common/md-multipath-retry-handling - there's also some locking
fixes etc in there.

The problem is our kernel has deviated so much from 2.4, and active
development is now focused on DM mpath in 2.6, that pulling out smaller
chunks and feeding them upstream on 2.4 just isn't worth it :-(


Sincerely,
    Lars Marowsky-Brée <lmb@suse.de>

-- 
High Availability & Clustering
SUSE Labs, Research and Development
SUSE LINUX Products GmbH - A Novell Business	 -- Charles Darwin
"Ignorance more frequently begets confidence than does knowledge"

-
To unsubscribe from this list: send the line "unsubscribe linux-raid" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2005-07-14 10:13 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-07-13 16:51 Oops when starting md multipath on a 2.4 kernel James Pearson
2005-07-14  5:48 ` Mike Tran
2005-07-14 10:09   ` James Pearson
2005-07-14 10:13     ` Lars Marowsky-Bree [this message]
2005-07-14 16:20     ` Luciano Chavez
2005-07-14 21:02       ` James Pearson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050714101329.GI25179@marowsky-bree.de \
    --to=lmb@suse.de \
    --cc=james-p@moving-picture.com \
    --cc=linux-raid@vger.kernel.org \
    --cc=lnx1138@us.ibm.com \
    --cc=mhtran@us.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).