From: Greg KH <greg@kroah.com>
To: NeilBrown <neilb@suse.de>
Cc: Andrew Morton <akpm@osdl.org>, linux-raid@vger.kernel.org
Subject: Re: [PATCH md 004 of 10] Fix some locking and module refcounting issues with md's use of sysfs.
Date: Wed, 2 Nov 2005 13:47:22 -0800 [thread overview]
Message-ID: <20051102214722.GF23247@kroah.com> (raw)
In-Reply-To: <1051102101510.23887@suse.de>
On Wed, Nov 02, 2005 at 09:15:10PM +1100, NeilBrown wrote:
>
> 1/ I really should be using the __ATTR macros for defining attributes, so
> that the .owner field get set properly, otherwise modules can be removed
> while sysfs files are open.
> This also involves some name changes of _show routines.
>
> 2/ Always lock the mddev (against reconfiguration) for all sysfs
> attribute access. This easily avoid certain races and is completely
> consistant with other interfaces (ioctl and /proc/mdstat both
> always lock against reconfiguration).
>
> 3/ raid5 attributes must check that the 'conf' structure actually
> exists (the array could have been stopped while an attribute file
> was open).
>
> 4/ A missing 'kfree' from when the raid5_conf_t was converted to have
> a kobject embedded, and then converted back again.
>
>
>
> Signed-off-by: Neil Brown <neilb@suse.de>
Acked-by: Greg Kroah-Hartman <gregkh@suse.de>
next prev parent reply other threads:[~2005-11-02 21:47 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-02 10:14 [PATCH md 000 of 10] Introduction NeilBrown
2005-11-02 10:14 ` [PATCH md 001 of 10] Make sure /block link in /sys/.../md/ goes to correct devices NeilBrown
2005-11-02 21:46 ` Greg KH
2005-11-02 10:14 ` [PATCH md 002 of 10] Make manual repair work for raid1 NeilBrown
2005-11-02 10:15 ` [PATCH md 003 of 10] Make sure a user-request sync of raid5 ignores intent bitmap NeilBrown
2005-11-02 10:15 ` [PATCH md 004 of 10] Fix some locking and module refcounting issues with md's use of sysfs NeilBrown
2005-11-02 21:47 ` Greg KH [this message]
2005-11-02 10:15 ` [PATCH md 005 of 10] Split off some md attributes in sysfs to a separate group NeilBrown
2005-11-02 21:48 ` Greg KH
2005-11-02 10:15 ` [PATCH md 006 of 10] Only try to print recovery/resync status for personalities that support recovery NeilBrown
2005-11-02 10:15 ` [PATCH md 007 of 10] Ignore auto-readonly flag for arrays where it isn't meaningful NeilBrown
2005-11-02 10:15 ` [PATCH md 008 of 10] Complete conversion of md to use kthreads NeilBrown
2005-11-02 10:15 ` [PATCH md 009 of 10] Improve 'scan_mode' and rename it to 'sync_action' NeilBrown
2005-11-02 21:49 ` Greg KH
2005-11-02 10:16 ` [PATCH md 010 of 10] Document sysfs usage of md, and make a couple of small refinements NeilBrown
2005-11-02 21:50 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051102214722.GF23247@kroah.com \
--to=greg@kroah.com \
--cc=akpm@osdl.org \
--cc=linux-raid@vger.kernel.org \
--cc=neilb@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).