From: Andrew Morton <akpm@osdl.org>
To: NeilBrown <neilb@suse.de>
Cc: linux-raid@vger.kernel.org
Subject: Re: [PATCH md 002 of 2] Make md threads interruptible again.
Date: Mon, 14 Nov 2005 18:08:05 -0800 [thread overview]
Message-ID: <20051114180805.01dbf4b9.akpm@osdl.org> (raw)
In-Reply-To: <1051115015641.9393@suse.de>
NeilBrown <neilb@suse.de> wrote:
>
>
> Despite the fact that md threads don't need to be signalled, and won't
> respond to signals anyway, we need to have an 'interruptible' wait,
> else they stay in 'D' state and add to the load average.
>
> ...
> + if (signal_pending(current))
> + flush_signals(current);
Kernel threads don't accept signals by default, so the above is unneeded.
I'll leave it in there now, since that's how things used to be, but please
make a note to nuke that check, then test it to make sure I'm telling the
truth, then fix it up later on?
next prev parent reply other threads:[~2005-11-15 2:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-15 1:56 [PATCH md 000 of 2] Introduction NeilBrown
2005-11-15 1:56 ` [PATCH md 001 of 2] Mark START_ARRAY deprecated with a date NeilBrown
2005-11-15 1:56 ` [PATCH md 002 of 2] Make md threads interruptible again NeilBrown
2005-11-15 2:08 ` Andrew Morton [this message]
2005-11-18 0:24 ` Neil Brown
2005-11-15 16:55 ` [PATCH md 000 of 2] Introduction Mr. James W. Laferriere
2005-11-17 5:12 ` Neil Brown
2005-11-17 16:19 ` Mr. James W. Laferriere
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051114180805.01dbf4b9.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=linux-raid@vger.kernel.org \
--cc=neilb@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).