From: Andrew Morton <akpm@osdl.org>
To: NeilBrown <neilb@suse.de>
Cc: linux-raid@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 005 of 13] md: Allow stripes to be expanded in preparation for expanding an array.
Date: Thu, 16 Mar 2006 21:50:47 -0800 [thread overview]
Message-ID: <20060316215047.65f411d4.akpm@osdl.org> (raw)
In-Reply-To: <1060317044745.16072@suse.de>
NeilBrown <neilb@suse.de> wrote:
>
> +static int resize_stripes(raid5_conf_t *conf, int newsize)
> +{
> + /* make all the stripes able to hold 'newsize' devices.
> + * New slots in each stripe get 'page' set to a new page.
> + * We allocate all the new stripes first, then if that succeeds,
> + * copy everything across.
> + * Finally we add new pages. This could fail, but we leave
> + * the stripe cache at it's new size, just with some pages empty.
> + *
> + * We use GFP_NOIO allocations as IO to the raid5 is blocked
> + * at some points in this operation.
> + */
> + struct stripe_head *osh, *nsh;
> + struct list_head newstripes, oldstripes;
You can use LIST_HEAD() here, avoid the separate INIT_LIST_HEAD().
> + struct disk_info *ndisks;
> + int err = 0;
> + kmem_cache_t *sc;
> + int i;
> +
> + if (newsize <= conf->pool_size)
> + return 0; /* never bother to shrink */
> +
> + sc = kmem_cache_create(conf->cache_name[1-conf->active_name],
> + sizeof(struct stripe_head)+(newsize-1)*sizeof(struct r5dev),
> + 0, 0, NULL, NULL);
kmem_cache_create() internally does a GFP_KERNEL allocation.
> + if (!sc)
> + return -ENOMEM;
> + INIT_LIST_HEAD(&newstripes);
> + for (i = conf->max_nr_stripes; i; i--) {
> + nsh = kmem_cache_alloc(sc, GFP_NOIO);
So either this can use GFP_KERNEL, or we have a problem.
next prev parent reply other threads:[~2006-03-17 5:50 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-17 4:47 [PATCH 000 of 13] md: Introduction NeilBrown
2006-03-17 4:47 ` [PATCH 001 of 13] md: Add '4' to the list of levels for which bitmaps are supported NeilBrown
2006-03-17 4:47 ` [PATCH 002 of 13] md: Fix the 'failed' count for version-0 superblocks NeilBrown
2006-03-17 4:47 ` [PATCH 003 of 13] md: Update status_resync to handle LARGE devices NeilBrown
2006-03-17 4:47 ` [PATCH 004 of 13] md: Split disks array out of raid5 conf structure so it is easier to grow NeilBrown
2006-03-17 4:47 ` [PATCH 005 of 13] md: Allow stripes to be expanded in preparation for expanding an array NeilBrown
2006-03-17 5:50 ` Andrew Morton [this message]
2006-03-17 6:04 ` Neil Brown
2006-03-17 5:53 ` Andrew Morton
2006-03-17 5:57 ` Andrew Morton
2006-03-17 6:24 ` Neil Brown
2006-03-17 4:47 ` [PATCH 006 of 13] md: Infrastructure to allow normal IO to continue while array is expanding NeilBrown
2006-03-17 6:01 ` Andrew Morton
2006-03-17 6:17 ` Neil Brown
2006-03-17 4:47 ` [PATCH 007 of 13] md: Core of raid5 resize process NeilBrown
2006-03-17 6:03 ` Andrew Morton
2006-03-17 7:10 ` Neil Brown
2006-03-17 4:48 ` [PATCH 008 of 13] md: Final stages of raid5 expand code NeilBrown
2006-03-17 4:48 ` [PATCH 009 of 13] md: Checkpoint and allow restart of raid5 reshape NeilBrown
2006-03-17 4:48 ` [PATCH 010 of 13] md: Only checkpoint expansion progress occasionally NeilBrown
2006-03-17 6:17 ` Andrew Morton
2006-03-17 4:48 ` [PATCH 011 of 13] md: Split reshape handler in check_reshape and start_reshape NeilBrown
2006-03-17 4:48 ` [PATCH 012 of 13] md: Make 'reshape' a possible sync_action action NeilBrown
2006-03-17 4:48 ` [PATCH 013 of 13] md: Support suspending of IO to regions of an md array NeilBrown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060316215047.65f411d4.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=neilb@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).