From: Jens Axboe <axboe@suse.de>
To: NeilBrown <neilb@suse.de>
Cc: Andrew Morton <akpm@osdl.org>,
linux-raid@vger.kernel.org, linux-kernel@vger.kernel.org,
Don Dupuis <dondster@gmail.com>
Subject: Re: [PATCH 002 of 2] md: Make sure bi_max_vecs is set properly in bio_split
Date: Mon, 22 May 2006 09:02:50 +0200 [thread overview]
Message-ID: <20060522070249.GC4216@suse.de> (raw)
In-Reply-To: <1060522061855.2861@suse.de>
On Mon, May 22 2006, NeilBrown wrote:
>
> Else a subsequence bio_clone might make a mess.
>
> Signed-off-by: Neil Brown <neilb@suse.de>
> Cc: "Don Dupuis" <dondster@gmail.com>
> Cc: Jens Axboe <axboe@suse.de>
> ### Diffstat output
> ./fs/bio.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff ./fs/bio.c~current~ ./fs/bio.c
> --- ./fs/bio.c~current~ 2006-05-22 16:12:46.000000000 +1000
> +++ ./fs/bio.c 2006-05-22 16:12:16.000000000 +1000
> @@ -1103,6 +1103,9 @@ struct bio_pair *bio_split(struct bio *b
> bp->bio1.bi_io_vec = &bp->bv1;
> bp->bio2.bi_io_vec = &bp->bv2;
>
> + bp->bio1.bi_max_vecs = 1;
> + bp->bio2.bi_max_vecs = 1;
> +
> bp->bio1.bi_end_io = bio_pair_end_1;
> bp->bio2.bi_end_io = bio_pair_end_2;
>
Obviously correct, thanks Neil.
--
Jens Axboe
prev parent reply other threads:[~2006-05-22 7:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-22 6:18 [PATCH 000 of 2] md: Introduction NeilBrown
2006-05-22 6:18 ` [PATCH 001 of 2] md: Fix possible oops when starting a raid0 array NeilBrown
2006-05-22 6:18 ` [PATCH 002 of 2] md: Make sure bi_max_vecs is set properly in bio_split NeilBrown
2006-05-22 7:02 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060522070249.GC4216@suse.de \
--to=axboe@suse.de \
--cc=akpm@osdl.org \
--cc=dondster@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=neilb@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).