From: Luca Berra <bluca@comedia.it>
To: linux-raid@vger.kernel.org
Cc: neilb@suse.de
Subject: [PATCH] missing close in mdassemble
Date: Wed, 13 Sep 2006 16:57:43 +0200 [thread overview]
Message-ID: <20060913145743.GH32581@percy.comedia.it> (raw)
[-- Attachment #1: Type: text/plain, Size: 272 bytes --]
attached, please apply
without this mdassemble cannot activate stacked arrays, i wonder how i
managed to miss it :(
L.
--
Luca Berra -- bluca@comedia.it
Communication Media & Services S.r.l.
/"\
\ / ASCII RIBBON CAMPAIGN
X AGAINST HTML MAIL
/ \
[-- Attachment #2: mdadm-2.5.3-closefd.patch --]
[-- Type: text/plain, Size: 537 bytes --]
--- mdadm-2.5.3/mdassemble.c.close 2006-09-13 12:28:00.000000000 +0200
+++ mdadm-2.5.3/mdassemble.c 2006-09-13 12:30:24.000000000 +0200
@@ -91,13 +91,12 @@
rv |= 1;
continue;
}
- if (ioctl(mdfd, GET_ARRAY_INFO, &array)>=0)
- /* already assembled, skip */
- continue;
+ if (ioctl(mdfd, GET_ARRAY_INFO, &array) < 0)
rv |= Assemble(array_list->st, array_list->devname, mdfd,
array_list,
NULL, NULL,
readonly, runstop, NULL, NULL, verbose, force);
+ close(mdfd);
}
return rv;
}
next reply other threads:[~2006-09-13 14:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-13 14:57 Luca Berra [this message]
2006-09-15 6:56 ` [PATCH] missing close in mdassemble Luca Berra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060913145743.GH32581@percy.comedia.it \
--to=bluca@comedia.it \
--cc=linux-raid@vger.kernel.org \
--cc=neilb@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).