From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg KH Subject: [patch 56/67] MD: Fix problem where hot-added drives are not resynced. Date: Wed, 11 Oct 2006 14:08:27 -0700 Message-ID: <20061011210827.GE16627@kroah.com> References: <20061011204756.642936754@quad.kroah.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline; filename="md-fix-problem-where-hot-added-drives-are-not-resynced.patch" In-Reply-To: <20061011210310.GA16627@kroah.com> Sender: linux-kernel-owner@vger.kernel.org To: linux-kernel@vger.kernel.org, stable@kernel.org, syrius.ml@no-log.org, Richard Bollinger Cc: Justin Forbes , Zwane Mwaikambo , Theodore Ts'o , Randy Dunlap , Dave Jones , Chuck Wolber , Chris Wedgwood , Michael Krufky , torvalds@osdl.org, akpm@osdl.org, alan@lxorguk.ukuu.org.uk, linux-raid@vger.kernel.org, Greg Kroah-Hartman List-Id: linux-raid.ids -stable review patch. If anyone has any objections, please let us know. ------------------ From: Neil Brown If a drive is added with HOT_ADD_DISK rather than ADD_NEW_DISK, saved_raid_disk isn't initialised properly, and the drive can be included in the array without a resync. From: Neil Brown Cc: Cc: Richard Bollinger Signed-off-by: Greg Kroah-Hartman --- drivers/md/md.c | 1 + 1 file changed, 1 insertion(+) --- linux-2.6.18.orig/drivers/md/md.c +++ linux-2.6.18/drivers/md/md.c @@ -3867,6 +3867,7 @@ static int hot_add_disk(mddev_t * mddev, } clear_bit(In_sync, &rdev->flags); rdev->desc_nr = -1; + rdev->saved_raid_disk = -1; err = bind_rdev_to_array(rdev, mddev); if (err) goto abort_export; --