* [patch 56/67] MD: Fix problem where hot-added drives are not resynced.
[not found] ` <20061011210310.GA16627@kroah.com>
@ 2006-10-11 21:08 ` Greg KH
0 siblings, 0 replies; only message in thread
From: Greg KH @ 2006-10-11 21:08 UTC (permalink / raw)
To: linux-kernel, stable, syrius.ml, Richard Bollinger
Cc: Justin Forbes, Zwane Mwaikambo, Theodore Ts'o, Randy Dunlap,
Dave Jones, Chuck Wolber, Chris Wedgwood, Michael Krufky,
torvalds, akpm, alan, linux-raid, Greg Kroah-Hartman
[-- Attachment #1: md-fix-problem-where-hot-added-drives-are-not-resynced.patch --]
[-- Type: text/plain, Size: 824 bytes --]
-stable review patch. If anyone has any objections, please let us know.
------------------
From: Neil Brown <neilb@suse.de>
If a drive is added with HOT_ADD_DISK rather than ADD_NEW_DISK,
saved_raid_disk isn't initialised properly, and the drive can be
included in the array without a resync.
From: Neil Brown <neilb@suse.de>
Cc: <syrius.ml@no-log.org>
Cc: Richard Bollinger <rabollinger@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
---
drivers/md/md.c | 1 +
1 file changed, 1 insertion(+)
--- linux-2.6.18.orig/drivers/md/md.c
+++ linux-2.6.18/drivers/md/md.c
@@ -3867,6 +3867,7 @@ static int hot_add_disk(mddev_t * mddev,
}
clear_bit(In_sync, &rdev->flags);
rdev->desc_nr = -1;
+ rdev->saved_raid_disk = -1;
err = bind_rdev_to_array(rdev, mddev);
if (err)
goto abort_export;
--
^ permalink raw reply [flat|nested] only message in thread