From: Jens Axboe <jens.axboe@oracle.com>
To: NeilBrown <neilb@suse.de>
Cc: Andrew Morton <akpm@osdl.org>,
linux-raid@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@kernel.org
Subject: Re: [PATCH] Check bio address after mapping through partitions.
Date: Tue, 31 Oct 2006 08:15:32 +0100 [thread overview]
Message-ID: <20061031071531.GT14055@kernel.dk> (raw)
In-Reply-To: <1061031015145.24246@suse.de>
On Tue, Oct 31 2006, NeilBrown wrote:
> This would be good for 2.6.19 and even 18.2, if it is seens acceptable.
> raid0 at least (possibly other) can be made to Oops with a bad partition
> table and best fix seem to be to not let out-of-range request get down
> to the device.
>
> ### Comments for Changeset
>
> Partitions are not limited to live within a device. So
> we should range check after partition mapping.
>
> Note that 'maxsector' was being used for two different things. I have
> split off the second usage into 'old_sector' so that maxsector can be
> still be used for it's primary usage later in the function.
>
> Cc: Jens Axboe <jens.axboe@oracle.com>
> Signed-off-by: Neil Brown <neilb@suse.de>
Code looks good to me, but for some reason your comment exceeds 80
chars. Can you please fix that up?
Acked-by: Jens Axboe <jens.axboe@oracle.com>
--
Jens Axboe
next prev parent reply other threads:[~2006-10-31 7:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20061031124940.24199.patches@notabene>
2006-10-31 1:51 ` [PATCH] Check bio address after mapping through partitions NeilBrown
2006-10-31 7:15 ` Jens Axboe [this message]
2006-10-31 10:49 ` [stable] " Chris Wright
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061031071531.GT14055@kernel.dk \
--to=jens.axboe@oracle.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=neilb@suse.de \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).