From: Andrew Morton <akpm@osdl.org>
To: ltuikov@yahoo.com
Cc: Jurriaan <thunder7@xs4all.nl>, "Rafael J. Wysocki" <rjw@sisk.pl>,
Jeff Garzik <jeff@garzik.org>, Neil Brown <neilb@suse.de>,
linux-kernel@vger.kernel.org, linux-raid@vger.kernel.org,
Tejun Heo <htejun@gmail.com>, Alan <alan@lxorguk.ukuu.org.uk>
Subject: Re: sata badness in 2.6.20-rc1? [Was: Re: md patches in -mm]
Date: Tue, 19 Dec 2006 16:08:40 -0800 [thread overview]
Message-ID: <20061219160840.bb6b155f.akpm@osdl.org> (raw)
In-Reply-To: <362582.18476.qm@web31811.mail.mud.yahoo.com>
On Tue, 19 Dec 2006 15:26:00 -0800 (PST)
Luben Tuikov <ltuikov@yahoo.com> wrote:
> The reason was that my dev tree was tainted by this bug:
>
> if (good_bytes &&
> - scsi_end_request(cmd, 1, good_bytes, !!result) == NULL)
> + scsi_end_request(cmd, 1, good_bytes, result == 0) == NULL)
> return;
>
> in scsi_io_completion(). I had there !!result which is wrong, and when
> I diffed against master, it produced a bad patch.
Oh. I thought that got sorted out. It's a shame this wasn't made clear to
me..
> As James mentioned one of the chunks is good and can go in.
Please send a new patch, not referential to any previous patch or email,
including full changelogging.
next prev parent reply other threads:[~2006-12-20 0:08 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20061204203410.6152efec.akpm@osdl.org>
[not found] ` <17780.63770.228659.234534@cse.unsw.edu.au>
[not found] ` <20061205061623.GA13749@amd64.of.nowhere>
[not found] ` <20061205062142.GA14784@amd64.of.nowhere>
[not found] ` <20061204224323.2e5d0494.akpm@osdl.org>
[not found] ` <20061205105928.GA6482@amd64.of.nowhere>
[not found] ` <17782.28505.303064.964551@cse.unsw.edu.au>
2006-12-15 19:21 ` md patches in -mm thunder7
2006-12-15 20:06 ` Andrew Morton
2006-12-15 20:50 ` sata badness in 2.6.20-rc1? [Was: Re: md patches in -mm] Neil Brown
2006-12-15 21:05 ` Andrew Morton
2006-12-15 21:18 ` Rafael J. Wysocki
2006-12-15 21:39 ` Andrew Morton
2006-12-15 21:46 ` Rafael J. Wysocki
2006-12-15 22:06 ` Alan
2006-12-15 22:04 ` Rafael J. Wysocki
2006-12-15 22:19 ` Jeff Garzik
2006-12-15 22:27 ` Rafael J. Wysocki
2006-12-15 22:22 ` Rafael J. Wysocki
2006-12-15 22:24 ` Jeff Garzik
2006-12-15 23:38 ` Rafael J. Wysocki
2006-12-16 9:56 ` Rafael J. Wysocki
2006-12-16 11:16 ` Rafael J. Wysocki
2006-12-17 11:00 ` Rafael J. Wysocki
2006-12-17 11:05 ` Andrew Morton
2006-12-17 16:00 ` thunder7
2006-12-19 23:26 ` Luben Tuikov
2006-12-20 0:08 ` Andrew Morton [this message]
2006-12-17 14:08 ` Jiri Slaby
2006-12-15 21:48 ` Jeff Garzik
2006-12-16 6:03 ` thunder7
2006-12-15 21:15 ` Rafael J. Wysocki
2006-12-15 21:49 ` Jeff Garzik
2006-12-15 21:56 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061219160840.bb6b155f.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=htejun@gmail.com \
--cc=jeff@garzik.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=ltuikov@yahoo.com \
--cc=neilb@suse.de \
--cc=rjw@sisk.pl \
--cc=thunder7@xs4all.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).