From: Lars Ellenberg <Lars.Ellenberg@linbit.com>
To: Ingo Molnar <mingo@redhat.com>,
Neil Brown <neilb@cse.unsw.edu.au>,
linux-raid@vger.kernel.org
Subject: [patch] latency problem in md driver
Date: Fri, 22 Dec 2006 15:32:16 +0100 [thread overview]
Message-ID: <20061222143215.GD7477@soda.linbit> (raw)
md raidX make_request functions strip off the BIO_RW_SYNC flag,
this introducing additional latency.
below is a suggested patch for the raid1.c .
other suggested solutions would be to let the bio_clone do its work,
and not reassign thereby stripping off all flags.
at most strip off known unwanted flags (the BARRIER flag).
similar pattern in the other raid versions.
cheers,
Lars
--- /mnt/kernel-src/linux-2.6.19/drivers/md/raid1.c.orig 2006-12-11 10:06:17.661776243 +0100
+++ /mnt/kernel-src/linux-2.6.19/drivers/md/raid1.c 2006-12-12 11:09:55.975762364 +0100
@@ -776,6 +776,7 @@ static int make_request(request_queue_t
struct page **behind_pages = NULL;
const int rw = bio_data_dir(bio);
int do_barriers;
+ int do_sync = bio_sync(bio);
/*
* Register the new request and wait if the reconstruction
@@ -835,7 +836,7 @@ static int make_request(request_queue_t
read_bio->bi_sector = r1_bio->sector + mirror->rdev->data_offset;
read_bio->bi_bdev = mirror->rdev->bdev;
read_bio->bi_end_io = raid1_end_read_request;
- read_bio->bi_rw = READ;
+ read_bio->bi_rw = READ | do_sync;
read_bio->bi_private = r1_bio;
generic_make_request(read_bio);
@@ -906,7 +907,7 @@ static int make_request(request_queue_t
mbio->bi_sector = r1_bio->sector + conf->mirrors[i].rdev->data_offset;
mbio->bi_bdev = conf->mirrors[i].rdev->bdev;
mbio->bi_end_io = raid1_end_write_request;
- mbio->bi_rw = WRITE | do_barriers;
+ mbio->bi_rw = WRITE | do_barriers | do_sync;
mbio->bi_private = r1_bio;
if (behind_pages) {
--
: Lars Ellenberg Tel +43-1-8178292-55 :
: LINBIT Information Technologies GmbH Fax +43-1-8178292-82 :
: Vivenotgasse 48, A-1120 Vienna/Europe http://www.linbit.com :
next reply other threads:[~2006-12-22 14:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-22 14:32 Lars Ellenberg [this message]
2006-12-22 15:19 ` [patch] latency problem in md driver Jeff Garzik
2006-12-22 15:37 ` Ric Wheeler
2006-12-22 15:40 ` Lars Ellenberg
2006-12-22 17:33 ` Lars Ellenberg
2006-12-22 20:40 ` Neil Brown
2006-12-26 13:09 ` Lars Ellenberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061222143215.GD7477@soda.linbit \
--to=lars.ellenberg@linbit.com \
--cc=linux-raid@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=neilb@cse.unsw.edu.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).