From: Jens Axboe <jens.axboe@oracle.com>
To: Neil Brown <neilb@suse.de>
Cc: Andrew Morton <akpm@osdl.org>,
Lars Ellenberg <Lars.Ellenberg@linbit.com>,
Ingo Molnar <mingo@redhat.com>,
linux-raid@vger.kernel.org, stable@kernel.org
Subject: Re: [patch] md: pass down BIO_RW_SYNC in raid{1,10}
Date: Tue, 9 Jan 2007 08:12:25 +0100 [thread overview]
Message-ID: <20070109071224.GG11203@kernel.dk> (raw)
In-Reply-To: <17826.55504.264610.856196@notabene.brown>
On Tue, Jan 09 2007, Neil Brown wrote:
> On Monday January 8, akpm@osdl.org wrote:
> > On Mon, 8 Jan 2007 10:08:34 +0100
> > Lars Ellenberg <Lars.Ellenberg@linbit.com> wrote:
> >
> > > md raidX make_request functions strip off the BIO_RW_SYNC flag,
> > > thus introducing additional latency.
> > >
> > > fixing this in raid1 and raid10 seems to be straight forward enough.
> > >
> > > for our particular usage case in DRBD, passing this flag improved
> > > some initialization time from ~5 minutes to ~5 seconds.
> >
> > That sounds like a significant fix.
> >
> > This patch also applies to 2.6.19 and I have tagged it for a -stable
> > backport. Neil, are you OK with that?
>
> Yes, I'm OK with that, thanks.
Ack from me as well, it's really a quite nasty bug from a performance
POV. Not just for DRDB, but for io schedulers as well.
--
Jens Axboe
next prev parent reply other threads:[~2007-01-09 7:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-08 9:08 [patch] md: pass down BIO_RW_SYNC in raid{1,10} Lars Ellenberg
2007-01-08 23:02 ` Andrew Morton
2007-01-08 23:50 ` Neil Brown
2007-01-09 7:12 ` Jens Axboe [this message]
2007-01-09 14:08 ` Lars Ellenberg
2007-01-09 16:13 ` Mike Snitzer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070109071224.GG11203@kernel.dk \
--to=jens.axboe@oracle.com \
--cc=Lars.Ellenberg@linbit.com \
--cc=akpm@osdl.org \
--cc=linux-raid@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=neilb@suse.de \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).