linux-raid.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Seyfried <seife@suse.de>
To: Tim Dijkstra <newsuser@famdijkstra.org>
Cc: suspend-devel List <suspend-devel@lists.sourceforge.net>,
	linux-raid@vger.kernel.org, 415441@bugs.debian.org
Subject: Re: [Suspend-devel] s2disk and raid
Date: Tue, 3 Apr 2007 18:34:26 +0200	[thread overview]
Message-ID: <20070403163425.GC5798@suse.de> (raw)
In-Reply-To: <20070403175521.70e6c876@commensaal.drs.p>

On Tue, Apr 03, 2007 at 05:55:21PM +0200, Tim Dijkstra wrote:
> Hi,
> 
> I've got a bugreport [0] from a user trying to use raid and uswsusp. He's
> using initramfs-tools available in debian. I'll describe the problem
> and my analysis, maybe you can comment on what you think. A warning: I only
> have a casual understanding of raid, never looked at any code related to it.
> 
> This is a setup where root maybe on raid, but swap isn't. Swap on raid
> will be very difficult to support, I think.

"it depends" :-)

> Now comes a crucial point. The script that finds the raid array, finds
> the array in an unclean state and starts syncing.

bad. Don't do that. Data will be lost.

> After this, resume finds an image in the swap partition and starts the
> resume process. Part of this process is freezing everything but itself,
> which fails on the process/thread that does the syncing.
> 
> IMO, the problem comes from the fact we started syncing, before we could
> start resume. 

Yes.
 
> Now the problem could theoretically be solved by not starting the
> assembly of the array once it is discovered, but modifying the 
> initramfs to do the assembly after we have had the chance to resume.

Yes.

> The debian-maintainer of mdadm thinks that the suspend process should
> have left the array in a clean state, but this is IMHO impossible. We
> are freezing userspace. A mdamd process looking after the array will
> probably get into trouble if we come back from suspend and we have
> done something to the array in the mean time.

Yes.
 
> What do you think?

You are right, he is wrong.
Do not touch anything before resume.
-- 
Stefan Seyfried

"Any ideas, John?"
"Well, surrounding them's out." 

  reply	other threads:[~2007-04-03 16:34 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-04-03 15:55 s2disk and raid Tim Dijkstra
2007-04-03 16:34 ` Stefan Seyfried [this message]
2007-04-03 19:00   ` [Suspend-devel] " Rafael J. Wysocki
2007-04-04  5:20 ` Neil Brown
2007-04-04 18:53   ` Tim Dijkstra
2007-04-04 20:47   ` Michael Tokarev
2007-04-12  5:37     ` Luis Rodrigo Gallardo Cruz
2007-04-17 18:58       ` Bug#415441: " Tim Dijkstra
2007-04-06  9:08   ` Luca Berra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070403163425.GC5798@suse.de \
    --to=seife@suse.de \
    --cc=415441@bugs.debian.org \
    --cc=linux-raid@vger.kernel.org \
    --cc=newsuser@famdijkstra.org \
    --cc=suspend-devel@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).