* multiple xor_block() functions
@ 2007-06-02 18:57 Adrian Bunk
[not found] ` <20070602185746.GI5500-HeJ8Db2Gnd6zQB+pC5nmwQ@public.gmane.org>
2007-06-04 17:48 ` Williams, Dan J
0 siblings, 2 replies; 3+ messages in thread
From: Adrian Bunk @ 2007-06-02 18:57 UTC (permalink / raw)
To: Dan Williams, mingo, neilb, John W. Linville, Jouni Malinen
Cc: linux-raid, linux-wireless, linux-kernel
include/linux/raid/xor.h:extern void xor_block(unsigned int count, unsigned int bytes, void **ptr);
drivers/md/xor.c:xor_block(unsigned int count, unsigned int bytes, void **ptr)
drivers/md/xor.c:EXPORT_SYMBOL(xor_block);
and
net/ieee80211/ieee80211_crypt_ccmp.c:static inline void xor_block(u8 * b, u8 * a, size_t len)
At least one of them has to be renamed.
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
^ permalink raw reply [flat|nested] 3+ messages in thread[parent not found: <20070602185746.GI5500-HeJ8Db2Gnd6zQB+pC5nmwQ@public.gmane.org>]
* Re: multiple xor_block() functions
[not found] ` <20070602185746.GI5500-HeJ8Db2Gnd6zQB+pC5nmwQ@public.gmane.org>
@ 2007-06-02 19:43 ` Jouni Malinen
0 siblings, 0 replies; 3+ messages in thread
From: Jouni Malinen @ 2007-06-02 19:43 UTC (permalink / raw)
To: Adrian Bunk
Cc: Dan Williams, mingo-H+wXaHxf7aLQT0dZR+AlfA, neilb-l3A5Bk7waGM,
John W. Linville, linux-raid-u79uwXL29TY76Z2rM5mHXA,
linux-wireless-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA
On Sat, Jun 02, 2007 at 08:57:46PM +0200, Adrian Bunk wrote:
> include/linux/raid/xor.h:extern void xor_block(unsigned int count, unsigned int bytes, void **ptr);
> drivers/md/xor.c:xor_block(unsigned int count, unsigned int bytes, void **ptr)
> drivers/md/xor.c:EXPORT_SYMBOL(xor_block);
>
> and
>
> net/ieee80211/ieee80211_crypt_ccmp.c:static inline void xor_block(u8 * b, u8 * a, size_t len)
>
>
> At least one of them has to be renamed.
Why? Not that I would really mind renaming one of these, but I don't see
a good reason for it. ieee80211_crypt_ccmp.c should not include
linux/raid/xor.h and the xor_block() in CCMP code is a static inline
function that should not show up outside the scope of this file. Do we
have some magic that makes exported symbols pollute name space for
inlined helper functions?
--
Jouni Malinen PGP id EFC895FA
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: multiple xor_block() functions
2007-06-02 18:57 multiple xor_block() functions Adrian Bunk
[not found] ` <20070602185746.GI5500-HeJ8Db2Gnd6zQB+pC5nmwQ@public.gmane.org>
@ 2007-06-04 17:48 ` Williams, Dan J
1 sibling, 0 replies; 3+ messages in thread
From: Williams, Dan J @ 2007-06-04 17:48 UTC (permalink / raw)
To: Adrian Bunk, mingo, neilb, John W. Linville, Jouni Malinen
Cc: linux-raid, linux-wireless, linux-kernel
> From: Adrian Bunk [mailto:bunk@stusta.de]
> include/linux/raid/xor.h:extern void xor_block(unsigned int count,
unsigned
> int bytes, void **ptr);
> drivers/md/xor.c:xor_block(unsigned int count, unsigned int bytes,
void **ptr)
> drivers/md/xor.c:EXPORT_SYMBOL(xor_block);
>
> and
>
> net/ieee80211/ieee80211_crypt_ccmp.c:static inline void xor_block(u8 *
b, u8 *
> a, size_t len)
>
>
> At least one of them has to be renamed.
>
I'll rename the raid version to 'xor_blocks' in the md-accel series. [
I would have suggested xor_n_blocks except that xor_blocks is limited to
5-blocks (MAX_XOR_BLOCKS) ]
>
> cu
> Adrian
>
Dan
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2007-06-04 17:48 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-06-02 18:57 multiple xor_block() functions Adrian Bunk
[not found] ` <20070602185746.GI5500-HeJ8Db2Gnd6zQB+pC5nmwQ@public.gmane.org>
2007-06-02 19:43 ` Jouni Malinen
2007-06-04 17:48 ` Williams, Dan J
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).