Linux RAID subsystem development
 help / color / mirror / Atom feed
From: Nagilum <nagilum@nagilum.org>
To: Neil Brown <neilb@suse.de>
Cc: linux-raid@vger.kernel.org
Subject: Re: Help RAID5 reshape Oops / backup-file
Date: Fri, 12 Oct 2007 08:43:28 +0200	[thread overview]
Message-ID: <20071012084328.2f6vk4cdw80kscw0@cakebox.homeunix.net> (raw)
In-Reply-To: <18190.46828.156191.300754@notabene.brown>

[-- Attachment #1: Type: text/plain, Size: 2815 bytes --]

----- Message from neilb@suse.de ---------
     Date: Fri, 12 Oct 2007 09:51:08 +1000
     From: Neil Brown <neilb@suse.de>
Reply-To: Neil Brown <neilb@suse.de>
  Subject: Re: Help RAID5 reshape Oops / backup-file
       To: Nagilum <nagilum@nagilum.org>
       Cc: linux-raid@vger.kernel.org


> On Thursday October 11, nagilum@nagilum.org wrote:
>> Ok, after looking in "Grow.c" I can see that the backup file is
>> removed once the critial section has passed:
>>
>> 		if (backup_file)
>> 			unlink(backup_file);
>>
>> 		printf(Name ": ... critical section passed.\n");
>>
>> Since I had passed that point I'll try to find out where
>> Grow_restart() stumbles. By looking at it I'm not even sure it's able
>> to "resume" and not just restart. :-/
>>
>
> It isn't a problem that you didn't specify a backup-file.
> If you don't, mdadm uses some spare space on one of the new drives.
> After the critical section has passed, the backup file isn't needed
> any longer.
> The problem is that mdadm still wants to find and recover from it.
>
> I throughly tested mdadm restarting from a crash during the critical
> section, but it looks like I didn't properly test restarting from a
> later crash.
>
> I think if you just change the 'return 1' at the end of Grow_restart
> to 'return 0' it should work for you.
>
> I'll try to get this fixed properly (and tested) and release a 2.6.4.
>
> NeilBrown
>


----- End message from neilb@suse.de -----

Thanks, I changed Grow_restart as suggested, now I get:
nas:~/mdadm-2.6.3# ./mdadm -A /dev/md0 /dev/sd[a-e]
mdadm: /dev/md0 assembled from 3 drives and 2 spares - not enough to  
start the array.

nas:~/mdadm-2.6.3# cat /proc/mdstat
Personalities : [raid6] [raid5] [raid4]
md0 : inactive sda[0] sde[6] sdd[5] sdc[2] sdb[1]
       2441543360 blocks

unused devices: <none>

which is similar to what the old mdadm is telling me.
I'll try to find out where it gets the idea these are spares..
Would it be a good idea to update to vanilla 2.6.23 instead of running  
Debian Etch's 2.6.18-5?
If there is anything I can do to help with v2.6.4 let me know!
Thanks,
Alex.

========================================================================
#    _  __          _ __     http://www.nagilum.org/ \n icq://69646724 #
#   / |/ /__ ____ _(_) /_ ____ _  nagilum@nagilum.org \n +491776461165 #
#  /    / _ `/ _ `/ / / // /  ' \  Amiga (68k/PPC): AOS/NetBSD/Linux   #
# /_/|_/\_,_/\_, /_/_/\_,_/_/_/_/   Mac (PPC): MacOS-X / NetBSD /Linux #
#           /___/     x86: FreeBSD/Linux/Solaris/Win2k  ARM9: EPOC EV6 #
========================================================================


----------------------------------------------------------------
cakebox.homeunix.net - all the machine one needs..


[-- Attachment #2: PGP Digital Signature --]
[-- Type: application/pgp-signature, Size: 187 bytes --]

  reply	other threads:[~2007-10-12  6:43 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-11 12:25 Help RAID5 reshape Oops / backup-file Nagilum
2007-10-11 23:51 ` Neil Brown
2007-10-12  6:43   ` Nagilum [this message]
2007-10-14 16:55     ` Nagilum
2007-10-14 23:31       ` Neil Brown
2007-10-15 11:55         ` Nagilum
2007-10-15 12:08           ` Nagilum
2007-10-16  1:16           ` Neil Brown
2007-10-16 12:50             ` Nagilum
2007-10-17 13:13               ` Nagilum
  -- strict thread matches above, loose matches on Subject: below --
2007-10-09 18:58 Nagilum

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071012084328.2f6vk4cdw80kscw0@cakebox.homeunix.net \
    --to=nagilum@nagilum.org \
    --cc=linux-raid@vger.kernel.org \
    --cc=neilb@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox