linux-raid.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Keld Jørn Simonsen" <keld@dkuug.dk>
To: Jon Nelson <jnelson-linux-raid@jamponi.net>
Cc: LinuxRaid <linux-raid@vger.kernel.org>
Subject: Re: Q: Is this how 'check' works (on raid10 in particular)?
Date: Tue, 5 Aug 2008 12:17:40 +0200	[thread overview]
Message-ID: <20080805101740.GB14670@rap.rap.dk> (raw)
In-Reply-To: <cccedfc60808041836s37637ff2x3d65543ab7d3d105@mail.gmail.com>

On Mon, Aug 04, 2008 at 08:36:33PM -0500, Jon Nelson wrote:
> The patch Keld sent me makes a significant difference:
> 
> Before:
> (Stock 2.6.25.11 x86-64 openSUSE 11.0 kernel raid10 module):   4.5h to 5.5h
> 
> After:
> Same kernel, minor changes to raid10.c and compiled:  1h 56m.
> 
> ::
> 
> Aug  4 18:37:09 turnip kernel: md: data-check of RAID array md0
> Aug  4 20:33:24 turnip kernel: md: md0: data-check done.
> 
> 
> > My idea is to do the checks in bigger blocks, then you would minimize
> > the trashing, by minimizing the number of times you need to move the
> > head.  And this would not need much change in the code. I have done a
> > patch to do this, but I have not yet tested it.

Thanks for testing it. It sounds good, and as I expected it to behave.
I think the patch is clean and I have sent it to the list and Neil for
inclusion in the tree.

Best regards
keld

      reply	other threads:[~2008-08-05 10:17 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-03 12:32 Q: Is this how 'check' works (on raid10 in particular)? Jon Nelson
2008-08-03 12:54 ` Keld Jørn Simonsen
2008-08-03 13:28   ` Keld Jørn Simonsen
2008-08-05  1:36   ` Jon Nelson
2008-08-05 10:17     ` Keld Jørn Simonsen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080805101740.GB14670@rap.rap.dk \
    --to=keld@dkuug.dk \
    --cc=jnelson-linux-raid@jamponi.net \
    --cc=linux-raid@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).