dmaengine: fix dependency chaining

dmaengine: fix dependency chaining

[Yuri Tikhonov]

In dmaengine we track the dependencies between the descriptors
using the 'next' pointers of the structure. These pointers are
set to NULL as soon as the corresponding descriptor has been
submitted to the channel (in dma_run_dependencies()).

But, the first 'next' in chain is still remaining set, regardless
the fact, that tx->next has been already submitted. This may lead to
multiple submissions of the same descriptor. This patch fixes this.

Actually, some previous implementation of the xxx_run_dependencies()
function already had this fix in place. The fdb..0eaf3 commit, beside the
correct things, broke this.

Signed-off-by: Yuri Tikhonov <yur@emcraft.com>
---
 drivers/dma/dmaengine.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/drivers/dma/dmaengine.c b/drivers/dma/dmaengine.c
index 403dbe7..6df144a 100644
--- a/drivers/dma/dmaengine.c
+++ b/drivers/dma/dmaengine.c
@@ -961,6 +961,8 @@ void dma_run_dependencies(struct dma_async_tx_descriptor *tx)
 	if (!dep)
 		return;
 
+	/* we'll submit tx->next now, so clear the link */
+	tx->next = NULL;
 	chan = dep->chan;
 
 	/* keep submitting up until a channel switch is detected
-- 
1.6.0.6

Re: dmaengine: fix dependency chaining

[Dan Williams]

On Mon, Jan 12, 2009 at 2:22 PM, Yuri Tikhonov <yur@emcraft.com> wrote:
> In dmaengine we track the dependencies between the descriptors
> using the 'next' pointers of the structure. These pointers are
> set to NULL as soon as the corresponding descriptor has been
> submitted to the channel (in dma_run_dependencies()).
>
> But, the first 'next' in chain is still remaining set, regardless
> the fact, that tx->next has been already submitted. This may lead to
> multiple submissions of the same descriptor. This patch fixes this.
>
> Actually, some previous implementation of the xxx_run_dependencies()
> function already had this fix in place. The fdb..0eaf3 commit, beside the
> correct things, broke this.
>
> Signed-off-by: Yuri Tikhonov <yur@emcraft.com>

Applied, thanks Yuri.

--
Dan