From: Andre Noll <maan@systemlinux.org>
To: Neil Brown <neilb@suse.de>
Cc: raz ben yehuda <raziebe@gmail.com>, linux-raid@vger.kernel.org
Subject: Re: Subject [ raid0 PATCH 3/6] : Add support to chunk size of 4K*n instead of 4K*2^n
Date: Wed, 20 May 2009 10:03:58 +0200 [thread overview]
Message-ID: <20090520080358.GR6403@skl-net.de> (raw)
In-Reply-To: <18961.65310.282446.521193@notabene.brown>
[-- Attachment #1: Type: text/plain, Size: 926 bytes --]
On Tue, May 19, 2009 at 10:36:46AM +1000, Neil Brown wrote:
> > diff --git a/drivers/md/raid0.c b/drivers/md/raid0.c
> > index 80ac685..dc2671f 100644
> > --- a/drivers/md/raid0.c
> > +++ b/drivers/md/raid0.c
> > @@ -23,6 +23,9 @@
> > #include "md.h"
> > #include "raid0.h"
> >
> > +static int handle_split(struct request_queue *q,
> > + unsigned int chunk_sects, struct bio *bio);
> > +
> > static void raid0_unplug(struct request_queue *q)
> > {
> > mddev_t *mddev = q->queuedata;
> > @@ -263,7 +266,12 @@ static int raid0_mergeable_bvec(struct request_queue *q,
> > unsigned int chunk_sectors = mddev->chunk_size >> 9;
>
> Hmm... if someone wanted to globally replace mddev->chunk_size with
> chunk_sectors, I wouldn't complain (Hi Andre :-)
Obviously I missed this one. Currently, mddev->chunk_size is in bytes,
that's probably why I missed it. I'll send a patch ASAP.
Thanks
Andre
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]
prev parent reply other threads:[~2009-05-20 8:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-18 23:05 Subject [ raid0 PATCH 3/6] : Add support to chunk size of 4K*n instead of 4K*2^n raz ben yehuda
2009-05-19 0:36 ` Neil Brown
2009-05-20 8:03 ` Andre Noll [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090520080358.GR6403@skl-net.de \
--to=maan@systemlinux.org \
--cc=linux-raid@vger.kernel.org \
--cc=neilb@suse.de \
--cc=raziebe@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).