From: Mike Snitzer <snitzer@redhat.com>
To: Neil Brown <neilb@suse.de>
Cc: linux-raid@vger.kernel.org, dm-devel@redhat.com,
Linus Torvalds <torvalds@linux-foundation.org>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Alasdair G Kergon <agk@redhat.com>
Subject: Re: md: Use new topology calls to indicate alignment and I/O sizes
Date: Wed, 24 Jun 2009 12:27:19 -0400 [thread overview]
Message-ID: <20090624162718.GA17052@redhat.com> (raw)
In-Reply-To: <20090624152748.GA16648@redhat.com>
On Wed, Jun 24 2009 at 11:27am -0400,
Mike Snitzer <snitzer@redhat.com> wrote:
> For some reason I thought you were aware of what Martin had put
> together. I assumed as much given you helped sort out some MD interface
> compile fixes in linux-next relative to topology-motivated changes.
> Anyway, not your fault that you didn't notice the core topology
> support.. It is likely a function of Martin having implemented the MD
> bits; you got this topology support "for free"; whereas I was forced to
> implement DM's topology support (and a few important changes to the core
> infrastructure).
Got these inverted:
> Here is a thread from April that discusses the core of the topology
> support:
http://marc.info/?t=124055146700007&r=1&w=4
> This post touches on naming and how userland tools are expected to
> consume the topology metrics:
http://marc.info/?l=linux-ide&m=124058535512850&w=4
>
> This post talks about the use of sysfs:
> http://marc.info/?l=linux-ide&m=124058543713031&w=4
...
> While I agree that adding these generic topology metrics to 'queue' may
> not be the perfect place I don't feel 'bdi' really helps userland
> understand them any better. Nor would userland really care. But I do
> agree that 'bdi' is likely a better place.
>
> You had mentioned your goal of removing MD's 'queue' entirely. Well DM
> already had that but Martin exposed a minimalist one as part of
> preparations for the topology support, see commit:
> cd43e26f071524647e660706b784ebcbefbd2e44
>
> This 'bdi' vs 'queue' discussion really stands to cause problems for
> userland. It would be unfortunate to force tools be aware of 2 places.
> Rather than "phase out legacy usage" of these brand new topology limits
> it would likely be wise to get it right the first time. Again, I'm OK
> with 'queue'; but Neil if you feel strongly about 'bdi' we should get a
> patch to Linus ASAP for 2.6.31.
>
> I can take a stab at it now if you don't have time.
On 2nd thought, bdi is inherently tied to mm and doesn't feel 'right';
I'll defer to Martin and Jens on this.
Regards,
Mike
next prev parent reply other threads:[~2009-06-24 16:27 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-23 4:54 [PATCH] md: Use new topology calls to indicate alignment and I/O sizes Martin K. Petersen
2009-06-23 21:44 ` Mike Snitzer
2009-06-24 4:05 ` Neil Brown
2009-06-24 5:03 ` Martin K. Petersen
2009-06-24 6:22 ` Neil Brown
2009-06-24 15:27 ` Mike Snitzer
2009-06-24 16:27 ` Mike Snitzer [this message]
2009-06-24 23:28 ` Neil Brown
2009-06-25 0:05 ` Martin K. Petersen
2009-06-24 17:07 ` [PATCH] " Martin K. Petersen
2009-06-25 2:35 ` Neil Brown
2009-06-25 4:37 ` Martin K. Petersen
2009-06-25 6:16 ` Neil Brown
2009-06-25 16:24 ` Martin K. Petersen
2009-06-30 20:24 ` Mike Snitzer
2009-06-30 23:58 ` Neil Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090624162718.GA17052@redhat.com \
--to=snitzer@redhat.com \
--cc=agk@redhat.com \
--cc=dm-devel@redhat.com \
--cc=linux-raid@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=neilb@suse.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).