From: scjody@sun.com
To: linux-ext4@vger.kernel.org, linux-raid@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, Andreas Dilger <adilger@sun.com>
Subject: [patch 5/5] [md] Add SET_RESYNC_ALL and CLEAR_RESYNC_ALL ioctls.
Date: Thu, 19 Nov 2009 16:22:46 -0500 [thread overview]
Message-ID: <20091119212407.911694324@sun.com> (raw)
In-Reply-To: 20091119212241.283629302@sun.com
[-- Attachment #1: md-add-syncall-ioctl.patch --]
[-- Type: TEXT/PLAIN, Size: 4190 bytes --]
This patch adds SET_RESYNC_ALL and CLEAR_RESYNC_ALL ioctls, needed for
fsck of a filesystem using declared mode.
SET_RESYNC_ALL instructs an MD block device to perform a resync of all
stripes read or written until CLEAR_RESYNC_ALL is set. The intended user
is e2fsck, which can SET_RESYNC_ALL before journal replay (which includes
reading from all blocks declared for write prior to a crash) and then
CLEAR_RESYNC_ALL afterwards.
Signed-off-by: Jody McIntyre <scjody@sun.com>
Index: linux-2.6.18-128.7.1/drivers/md/md.c
===================================================================
--- linux-2.6.18-128.7.1.orig/drivers/md/md.c
+++ linux-2.6.18-128.7.1/drivers/md/md.c
@@ -4484,6 +4484,24 @@ static int md_ioctl(struct inode *inode,
err = set_bitmap_file(mddev, (int)arg);
goto done_unlock;
+ case SET_RESYNC_ALL:
+ if (mddev->pers->set_resync_all == NULL) {
+ err = -EINVAL;
+ goto abort_unlock;
+ }
+
+ err = mddev->pers->set_resync_all(mddev, 1);
+ goto done_unlock;
+
+ case CLEAR_RESYNC_ALL:
+ if (mddev->pers->set_resync_all == NULL) {
+ err = -EINVAL;
+ goto abort_unlock;
+ }
+
+ err = mddev->pers->set_resync_all(mddev, 0);
+ goto done_unlock;
+
default:
err = -EINVAL;
goto abort_unlock;
Index: linux-2.6.18-128.7.1/drivers/md/raid5.c
===================================================================
--- linux-2.6.18-128.7.1.orig/drivers/md/raid5.c
+++ linux-2.6.18-128.7.1/drivers/md/raid5.c
@@ -3013,7 +3013,7 @@ retry:
r_sector += sectors_per_chunk;
}
if (sh) {
- if (bio_flagged(bi, BIO_SYNCRAID)) {
+ if (bio_flagged(bi, BIO_SYNCRAID) || conf->resync_all) {
if (test_bit(STRIPE_RESYNC_REQ, &sh->state)) {
PRINTK("SYNCRAID on %llu, already resynced\n", bi->bi_sector);
} else {
@@ -4049,6 +4049,15 @@ static void raid5_quiesce(mddev_t *mddev
}
}
+static int raid5_set_resync_all(mddev_t *mddev, int state)
+{
+ raid5_conf_t *conf = mddev_to_conf(mddev);
+
+ conf->resync_all = state;
+
+ return 0;
+}
+
static struct mdk_personality raid6_personality =
{
.name = "raid6",
@@ -4065,6 +4074,7 @@ static struct mdk_personality raid6_pers
.sync_request = sync_request,
.resize = raid5_resize,
.quiesce = raid5_quiesce,
+ .set_resync_all = raid5_set_resync_all,
};
static struct mdk_personality raid5_personality =
{
@@ -4086,6 +4096,7 @@ static struct mdk_personality raid5_pers
.start_reshape = raid5_start_reshape,
#endif
.quiesce = raid5_quiesce,
+ .set_resync_all = raid5_set_resync_all,
};
static struct mdk_personality raid4_personality =
@@ -4104,6 +4115,7 @@ static struct mdk_personality raid4_pers
.sync_request = sync_request,
.resize = raid5_resize,
.quiesce = raid5_quiesce,
+ .set_resync_all = raid5_set_resync_all,
};
static int __init raid5_init(void)
Index: linux-2.6.18-128.7.1/include/linux/raid/md_u.h
===================================================================
--- linux-2.6.18-128.7.1.orig/include/linux/raid/md_u.h
+++ linux-2.6.18-128.7.1/include/linux/raid/md_u.h
@@ -45,6 +45,8 @@
#define STOP_ARRAY _IO (MD_MAJOR, 0x32)
#define STOP_ARRAY_RO _IO (MD_MAJOR, 0x33)
#define RESTART_ARRAY_RW _IO (MD_MAJOR, 0x34)
+#define SET_RESYNC_ALL _IO (MD_MAJOR, 0x35)
+#define CLEAR_RESYNC_ALL _IO (MD_MAJOR, 0x36)
typedef struct mdu_version_s {
int major;
Index: linux-2.6.18-128.7.1/include/linux/raid/raid5.h
===================================================================
--- linux-2.6.18-128.7.1.orig/include/linux/raid/raid5.h
+++ linux-2.6.18-128.7.1/include/linux/raid/raid5.h
@@ -241,6 +241,7 @@ struct raid5_private_data {
int seq_flush, seq_write;
int quiesce;
+ int resync_all;
int fullsync; /* set to 1 if a full sync is needed,
* (fresh device added).
Index: linux-2.6.18-128.7.1/include/linux/raid/md_k.h
===================================================================
--- linux-2.6.18-128.7.1.orig/include/linux/raid/md_k.h
+++ linux-2.6.18-128.7.1/include/linux/raid/md_k.h
@@ -283,6 +283,7 @@ struct mdk_personality
* others - reserved
*/
void (*quiesce) (mddev_t *mddev, int state);
+ int (*set_resync_all) (mddev_t *mddev, int state);
};
--
next prev parent reply other threads:[~2009-11-19 21:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-19 21:22 [patch 0/5] Journal guided resync and support scjody
2009-11-19 21:22 ` [patch 1/5] [md] Add fs_raidsync buffer & bio flags scjody
2009-11-19 21:22 ` [patch 2/5] [md] Add syncraid " scjody
2009-11-19 21:22 ` [patch 3/5] [jbd] Add support for journal guided resync scjody
2009-11-19 21:22 ` [patch 4/5] [ext3] Add journal guided resync (data=declared mode) scjody
2009-11-19 21:22 ` scjody [this message]
2009-11-24 11:43 ` [patch 0/5] Journal guided resync and support Pavel Machek
2009-11-24 18:51 ` Andreas Dilger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091119212407.911694324@sun.com \
--to=scjody@sun.com \
--cc=adilger@sun.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).