From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Williams Subject: [PATCH] md: make recovery started by do_md_run() visible via sync_action Date: Mon, 21 Dec 2009 18:18:36 -0700 Message-ID: <20091222011305.27523.26165.stgit@dwillia2-linux.ch.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Return-path: Sender: linux-raid-owner@vger.kernel.org To: neilb@suse.de Cc: ed.ciechanowski@intel.com, marcin.labun@intel.com, linux-raid@vger.kernel.org List-Id: linux-raid.ids By default md_do_sync() will perform recovery if no other actions are specified. However, action_show() relies on MD_RECOVERY_RECOVER to be set otherwise it returns 'idle'. So, add a missing set MD_RECOVERY_RECOVER when starting recovery. Signed-off-by: Dan Williams --- Hi Neil, One more to finish off recovery checkpoint support. Without this mdmon never notices that the array was rebuilding and never marks the completion. I did not see any urgency to workaround this in the mdadm patchset, but let me know if you think a "kernel version > 2.6.33-rcX" check is warranted. Thanks, Dan drivers/md/md.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/md/md.c b/drivers/md/md.c index 1cc5f2d..fa93de0 100644 --- a/drivers/md/md.c +++ b/drivers/md/md.c @@ -4286,6 +4286,7 @@ static int do_md_run(mddev_t * mddev) if (spares && mddev->pers->sync_request) { mddev->recovery = 0; set_bit(MD_RECOVERY_RUNNING, &mddev->recovery); + set_bit(MD_RECOVERY_RECOVER, &mddev->recovery); mddev->sync_thread = md_register_thread(md_do_sync, mddev, "resync");