From: Andre Noll <maan@systemlinux.org>
To: Artur Wojcik <artur.wojcik@intel.com>
Cc: linux-raid@vger.kernel.org, dan.j.williams@intel.com,
ed.ciechanowski@intel.com
Subject: Re: [mdadm PATCH] Move symbol definitions from source files to Makefile.
Date: Thu, 28 Jan 2010 18:02:59 +0100 [thread overview]
Message-ID: <20100128170259.GU7517@skl-net.de> (raw)
In-Reply-To: <20100128154745.31726.15500.stgit@awojcik-linux>
[-- Attachment #1: Type: text/plain, Size: 739 bytes --]
On 16:47, Artur Wojcik wrote:
> This patch will move _GNU_SOURCE and _FILE_OFFSET_BITS=64 from
> various source files to Makefile.
That's fine by me, but let's see what Neil has to say about this.
While cleaning up the #defines, we might want to get rid of a couple
of unused ones at the same time. BLKPG_ADD_PARTITION, START_MD,
REGISTER_DEV, MD_FEATURE_ALL, STDC, OF seem to be good candidates
for removal.
There are also quite some unused defines in super-ddf.c and
super-intel.c, presumably because these files contain code that was
copied from somewhere else. I'm not sure if it is worth to kill these
as well though.
Thanks
Andre
--
The only person who always got his work done by Friday was Robinson Crusoe
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2010-01-28 17:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-28 15:47 [mdadm PATCH] Move symbol definitions from source files to Makefile Artur Wojcik
2010-01-28 17:02 ` Andre Noll [this message]
2010-01-29 9:45 ` Neil Brown
2010-01-29 15:05 ` Artur Wojcik
2010-01-29 21:54 ` Neil Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100128170259.GU7517@skl-net.de \
--to=maan@systemlinux.org \
--cc=artur.wojcik@intel.com \
--cc=dan.j.williams@intel.com \
--cc=ed.ciechanowski@intel.com \
--cc=linux-raid@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).