From: Christoph Hellwig <hch@infradead.org>
To: Jun'ichi Nomura <j-nomura@ce.jp.nec.com>
Cc: Fran?ois Figarola <francois.figarola@i-consult.fr>,
hch@infradead.org,
device-mapper development <dm-devel@redhat.com>,
linux-kernel@vger.kernel.org, Neil Brown <neilb@suse.de>,
Andrew Morton <akpm@linux-foundation.org>,
linux-raid@vger.kernel.org, Al Viro <viro@zeniv.linux.org.uk>
Subject: Re: [dm-devel] [BUG] kernel 2.6.32.x hangs during boot process
Date: Thu, 28 Jan 2010 13:25:28 -0500 [thread overview]
Message-ID: <20100128182528.GA29926@infradead.org> (raw)
In-Reply-To: <4B612F89.7020503@ce.jp.nec.com>
On Thu, Jan 28, 2010 at 03:32:41PM +0900, Jun'ichi Nomura wrote:
> When MS_RDONLY, both freeze_bdev and thaw_bdev call deactivate_locked_super,
> which seems wrong. The change was introduced with the commit below:
>
> commit 4504230a71566785a05d3e6b53fa1ee071b864eb
> Author: Christoph Hellwig <hch@lst.de>
> Date: Mon Aug 3 23:28:35 2009 +0200
>
> freeze_bdev: grab active reference to frozen superblocks
>
> With the attached patch, both remount-ro and remount-rw are
> rejected as EBUSY on freezed device as expected.
>
> Christoph, do you think this is the right fix?
Indeed, this looks wrong in my original code, and the patch looks like
the correct fix. Thanks a lot!
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2010-01-28 18:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <d2deb3241001160158r4baed1e1t7e8f6642de018b4c@mail.gmail.com>
2010-01-23 0:07 ` [BUG] kernel 2.6.32.x hangs during boot process Andrew Morton
2010-01-28 2:42 ` Neil Brown
2010-01-28 6:32 ` [dm-devel] " Jun'ichi Nomura
2010-01-28 18:16 ` Thomas Backlund
2010-01-28 18:25 ` Christoph Hellwig [this message]
2010-01-29 0:56 ` [BUGFIX] [PATCH] freeze_bdev: don't deactivate successfully frozen MS_RDONLY sb Jun'ichi Nomura
2010-01-30 18:44 ` Thomas Backlund
2010-01-29 7:06 ` [dm-devel] [BUG] kernel 2.6.32.x hangs during boot process François Figarola
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100128182528.GA29926@infradead.org \
--to=hch@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=dm-devel@redhat.com \
--cc=francois.figarola@i-consult.fr \
--cc=j-nomura@ce.jp.nec.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=neilb@suse.de \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).