From: Neil Brown <neilb@suse.de>
To: Artur Wojcik <artur.wojcik@intel.com>
Cc: "linux-raid@vger.kernel.org" <linux-raid@vger.kernel.org>,
"Williams, Dan J" <dan.j.williams@intel.com>,
"Ciechanowski, Ed" <ed.ciechanowski@intel.com>
Subject: Re: [mdadm PATCH] Move symbol definitions from source files to Makefile.
Date: Sat, 30 Jan 2010 08:54:38 +1100 [thread overview]
Message-ID: <20100130085438.41956bb5@notabene> (raw)
In-Reply-To: <1264777558.2788.37.camel@awojcik-linux>
On Fri, 29 Jan 2010 16:05:58 +0100
Artur Wojcik <artur.wojcik@intel.com> wrote:
> On Fri, 2010-01-29 at 09:45 +0000, Neil Brown wrote:
> > On Thu, 28 Jan 2010 16:47:45 +0100
> > Artur Wojcik <artur.wojcik@intel.com> wrote:
> >
> > > This patch will move _GNU_SOURCE and _FILE_OFFSET_BITS=64 from
> > > various source files to Makefile.
> >
> > Why?
> >
>
> The reason is to clean up the code. The new files will appear soon and I
> want this two definitions to be set globally instead of per source file.
Personally, I prefer them to be set just where they are needed. You could
possibly convince me to put them in mdadm.h, but not in Makefile.
>
> There's the plan to use GNU autotools to simply the build process, too.
That plan should be dropped immediately. It won't happen.
NeilBrown
prev parent reply other threads:[~2010-01-29 21:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-28 15:47 [mdadm PATCH] Move symbol definitions from source files to Makefile Artur Wojcik
2010-01-28 17:02 ` Andre Noll
2010-01-29 9:45 ` Neil Brown
2010-01-29 15:05 ` Artur Wojcik
2010-01-29 21:54 ` Neil Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100130085438.41956bb5@notabene \
--to=neilb@suse.de \
--cc=artur.wojcik@intel.com \
--cc=dan.j.williams@intel.com \
--cc=ed.ciechanowski@intel.com \
--cc=linux-raid@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).