From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Michael S. Tsirkin" Subject: Re: compat_ioctl: ignore RAID_VERSION ioctl Date: Sun, 7 Feb 2010 11:24:09 +0200 Message-ID: <20100207092407.GA19684@redhat.com> References: <20100130205353.GA3168@redhat.com> <201001302302.10574.arnd@arndb.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <201001302302.10574.arnd@arndb.de> Sender: linux-kernel-owner@vger.kernel.org To: Arnd Bergmann Cc: "Rafael J. Wysocki" , Linux Kernel Mailing List , neilb@suse.de, linux-raid@vger.kernel.org, dm-devel@redhat.com, maan@systemlinux.org List-Id: linux-raid.ids On Sat, Jan 30, 2010 at 11:02:10PM +0100, Arnd Bergmann wrote: > md ioctls are now handled by the md driver itself, but mdadm > may call RAID_VERSION on other devices as well. Mark the command > as IGNORE_IOCTL so this fails silently rather than printing > an annoying message. > > Signed-off-by: Arnd Bergmann The patch does not seem to be there in -rc7. Since this is fixes a regression, should this go into 2.6.33? Thanks! > --- > > On Saturday 30 January 2010, Michael S. Tsirkin wrote: > > Under 2.6.33-rcX (at least rc5 and rc6, didn't check earlier versions), > > I started seeing these messages in dmesg (I do not see these messages on 2.6.32): > > > > [ 16.528951] ioctl32(mdadm:2243): Unknown cmd fd(3) cmd(800c0910){t:09;sz:12} arg(ffb7f9c4) on /dev/sda9 > > Does this help? > > --- a/fs/compat_ioctl.c > +++ b/fs/compat_ioctl.c > @@ -1038,6 +1038,8 @@ COMPATIBLE_IOCTL(FIOQSIZE) > #ifdef CONFIG_BLOCK > /* loop */ > IGNORE_IOCTL(LOOP_CLR_FD) > +/* md calls this on random blockdevs */ > +IGNORE_IOCTL(RAID_VERSION) > /* SG stuff */ > COMPATIBLE_IOCTL(SG_SET_TIMEOUT) > COMPATIBLE_IOCTL(SG_GET_TIMEOUT) >